Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explain how to update the changelog #4372

Merged
merged 4 commits into from Aug 21, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Aug 12, 2019

cc @Manishearth Is this more or less how you did it last time?

Rendered

changelog: none

@phansch
Copy link
Member Author

phansch commented Aug 12, 2019

Image for the text
Selection_064

bors added a commit that referenced this pull request Aug 12, 2019
Filter out PRs with changelog: none

cc #4372

Filtering out the `changelog: none` merge commits, to unclutter the output.

changelog: none
doc/changelog_update.md Show resolved Hide resolved
doc/changelog_update.md Outdated Show resolved Hide resolved
doc/changelog_update.md Outdated Show resolved Hide resolved
bors added a commit that referenced this pull request Aug 12, 2019
Filter out PRs with changelog: none

cc #4372

Filtering out the `changelog: none` merge commits, to unclutter the output.

changelog: none
bors added a commit that referenced this pull request Aug 12, 2019
Filter out PRs with changelog: none

cc #4372

Filtering out the `changelog: none` merge commits, to unclutter the output.

changelog: none
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 12, 2019
doc/changelog_update.md Show resolved Hide resolved
@flip1995
Copy link
Member

flip1995 commented Aug 21, 2019

@phansch Since you most recently updated the changelog, you're the best one to judge, whether the documentation is comprehensive. If you think it is, r=me

@phansch
Copy link
Member Author

phansch commented Aug 21, 2019

@phansch Since you most recently updated the changelog, you're the best one to judge, whether the documentation is comprehensive. If you think it is, r=me

I'll probably come up with more improvements the next time around, but I think this is good enough to get other people started, too.

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Aug 21, 2019

📌 Commit a0f9af2 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Aug 21, 2019

Testing commit a0f9af2 with merge 6d9ee9e...

bors added a commit that referenced this pull request Aug 21, 2019
docs: Explain how to update the changelog

cc @Manishearth Is this more or less how you did it last time?

[Rendered](https://github.com/phansch/rust-clippy/blob/changelog_update/doc/changelog_update.md#changelog-update)

changelog: none
@bors
Copy link
Contributor

bors commented Aug 21, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 6d9ee9e to master...

@bors bors merged commit a0f9af2 into rust-lang:master Aug 21, 2019
@phansch phansch deleted the changelog_update branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants