Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in derive_hash_xor_eq #4766

Merged
merged 1 commit into from Nov 23, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Nov 1, 2019

This fixes a false positive in derive_hash_xor_eq where the lint was
triggering on user-defined traits called Hash.

changelog: Fix false positive in derive_hash_xor_eq

Fixes #4658

@JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Nov 5, 2019

Seems stderr needs to be updated

@JohnTitor JohnTitor added the S-waiting-on-author label Nov 5, 2019
This fixes a false positive in derive_hash_xor_eq where the lint was
triggering on user-defined traits called `Hash`.
@phansch phansch force-pushed the fix_fp_in_derive_hash_xor_eq branch from 13e3caf to 78b7e85 Compare Nov 11, 2019
@phansch
Copy link
Member Author

@phansch phansch commented Nov 11, 2019

Yup, forgot to commit the updated .stderr file.

@phansch phansch added S-waiting-on-review and removed S-waiting-on-author labels Nov 11, 2019
Copy link
Member

@flip1995 flip1995 left a comment

r=me with rustup.

@flip1995
Copy link
Member

@flip1995 flip1995 commented Nov 23, 2019

@bors r+ rollup

@bors
Copy link
Contributor

@bors bors commented Nov 23, 2019

📌 Commit 78b7e85 has been approved by flip1995

flip1995 added a commit to flip1995/rust-clippy that referenced this issue Nov 23, 2019
…, r=flip1995

Fix false positive in derive_hash_xor_eq

This fixes a false positive in derive_hash_xor_eq where the lint was
triggering on user-defined traits called `Hash`.

changelog: Fix false positive in `derive_hash_xor_eq`

Fixes rust-lang#4658
bors added a commit that referenced this issue Nov 23, 2019
Rollup of 6 pull requests

Successful merges:

 - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body)
 - #4764 (Allow casts from the result of `checked_abs` to unsigned)
 - #4766 (Fix false positive in derive_hash_xor_eq)
 - #4811 (Literal Representation Restructure)
 - #4820 (doc: fix the comment above the lint function)
 - #4830 (use more efficient code to generate repeated string)

Failed merges:

r? @ghost

changelog: none
flip1995 added a commit to flip1995/rust-clippy that referenced this issue Nov 23, 2019
…, r=flip1995

Fix false positive in derive_hash_xor_eq

This fixes a false positive in derive_hash_xor_eq where the lint was
triggering on user-defined traits called `Hash`.

changelog: Fix false positive in `derive_hash_xor_eq`

Fixes rust-lang#4658
bors added a commit that referenced this issue Nov 23, 2019
Rollup of 5 pull requests

Successful merges:

 - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body)
 - #4766 (Fix false positive in derive_hash_xor_eq)
 - #4811 (Literal Representation Restructure)
 - #4820 (doc: fix the comment above the lint function)
 - #4830 (use more efficient code to generate repeated string)

Failed merges:

r? @ghost
bors added a commit that referenced this issue Nov 23, 2019
Rollup of 5 pull requests

Successful merges:

 - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body)
 - #4766 (Fix false positive in derive_hash_xor_eq)
 - #4811 (Literal Representation Restructure)
 - #4820 (doc: fix the comment above the lint function)
 - #4830 (use more efficient code to generate repeated string)

Failed merges:

r? @ghost

changelog: none
@bors bors merged commit 78b7e85 into rust-lang:master Nov 23, 2019
1 check passed
@phansch phansch deleted the fix_fp_in_derive_hash_xor_eq branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants