Skip to content

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Oct 9, 2020

This updates all of our action dependencies and removes every usage of set-env. set-env and add-path has been deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

changelog: none

@rust-highfive
Copy link

r? @ebroto

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 9, 2020
@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

@bors try

@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Trying commit 2b370bf with merge 7fad4d8...

bors added a commit that referenced this pull request Oct 9, 2020
Remove deprecated set-env from GHA

This updates all of our action dependencies and removes every usage of `set-env`. `set-env` and `add-path` has been deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

changelog: none
@flip1995 flip1995 changed the title Remove deprecated set-env from GHA [WIP] Remove deprecated set-env from GHA Oct 9, 2020
@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

Debugging CI, yay 🎉 😭

And why: Because Windows.

@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

@bors try

bors added a commit that referenced this pull request Oct 9, 2020
[WIP] Remove deprecated set-env from GHA

This updates all of our action dependencies and removes every usage of `set-env`. `set-env` and `add-path` has been deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

changelog: none
@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Trying commit 7d81b6d with merge e82c54e...

@bors
Copy link
Contributor

bors commented Oct 9, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

@bors try

@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Trying commit 27971ed with merge a817a18...

bors added a commit that referenced this pull request Oct 9, 2020
[WIP] Remove deprecated set-env from GHA

This updates all of our action dependencies and removes every usage of `set-env`. `set-env` and `add-path` has been deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

changelog: none
@bors
Copy link
Contributor

bors commented Oct 9, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

@bors try

@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Trying commit 88f63ac with merge aed040c...

bors added a commit that referenced this pull request Oct 9, 2020
[WIP] Remove deprecated set-env from GHA

This updates all of our action dependencies and removes every usage of `set-env`. `set-env` and `add-path` has been deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

changelog: none
@bors
Copy link
Contributor

bors commented Oct 9, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

@bors try

bors added a commit that referenced this pull request Oct 9, 2020
[WIP] Remove deprecated set-env from GHA

This updates all of our action dependencies and removes every usage of `set-env`. `set-env` and `add-path` has been deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

changelog: none
@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Trying commit a735d17 with merge 7a9b6c1...

@bors
Copy link
Contributor

bors commented Oct 9, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

@bors try

bors added a commit that referenced this pull request Oct 9, 2020
[WIP] Remove deprecated set-env from GHA

This updates all of our action dependencies and removes every usage of `set-env`. `set-env` and `add-path` has been deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

changelog: none
@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Trying commit a36c8e5 with merge 0e6b70c...

@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

@bors try

@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Trying commit c4c9453 with merge a4a92bf...

bors added a commit that referenced this pull request Oct 9, 2020
[WIP] Remove deprecated set-env from GHA

This updates all of our action dependencies and removes every usage of `set-env`. `set-env` and `add-path` has been deprecated: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

changelog: none
@bors
Copy link
Contributor

bors commented Oct 9, 2020

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: a4a92bf (a4a92bf1ffe77bbfab874ca4d8ee76a03b34a052)

@flip1995 flip1995 changed the title [WIP] Remove deprecated set-env from GHA Remove deprecated set-env from GHA Oct 9, 2020
@flip1995
Copy link
Member Author

flip1995 commented Oct 9, 2020

Ready for review 🚀

Copy link
Contributor

@ebroto ebroto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebroto
Copy link
Contributor

ebroto commented Oct 9, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Oct 9, 2020

📌 Commit c4c9453 has been approved by ebroto

@ebroto ebroto removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 9, 2020
@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Testing commit c4c9453 with merge 36e3c41...

@bors
Copy link
Contributor

bors commented Oct 9, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 36e3c41 to master...

@bors bors merged commit 36e3c41 into rust-lang:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants