fix missing_panics_doc not detecting assert_eq! and assert_ne!

[ABouttefeux]

fixes #6997
changelog: missing_panics_doc detects assert_eq! and assert_ne!

---

searching for assert_eq! and assert_ne! in FindPanicUnwrap

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[ABouttefeux]

(Outdated)

I am not sure this the way to correct it. But is seems that even if core::panicking::assert_failed_inner use panic! it is not detected. I am not sure why.

I was also thinking to add

if is_expn_of(expr.span, "assert_eq").is_some() || is_expn_of(expr.span, "assert_ne").is_some() {
    self.panic_span = Some(expr.span);
}

in clippy_lints\src\doc.rs, FindPanicUnwrap::visit_expr instead.

[Manishearth]

Can you add a test for this?

[ABouttefeux]

sure :)

[Manishearth]

@bors r+

[bors]

📌 Commit 8e5dd4b has been approved by Manishearth

[bors]

⌛ Testing commit 8e5dd4b with merge 25c1ed3...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 25c1ed3 to master...