Skip to content

Conversation

Y-Nak
Copy link
Contributor

@Y-Nak Y-Nak commented Jun 5, 2021

fixes #7304

changelog: Fix default_numeric_fallback FP with external macro expansion

@rust-highfive
Copy link

r? @phansch

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 5, 2021
@Y-Nak Y-Nak force-pushed the numeric-fallback branch from 1efb87b to d7a380e Compare June 6, 2021 03:44
@giraffate
Copy link
Contributor

@bors r+

It looks good, thanks!

@bors
Copy link
Contributor

bors commented Jun 8, 2021

📌 Commit d7a380e has been approved by giraffate

@bors
Copy link
Contributor

bors commented Jun 8, 2021

⌛ Testing commit d7a380e with merge c1577ab...

@bors
Copy link
Contributor

bors commented Jun 8, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing c1577ab to master...

@bors bors merged commit c1577ab into rust-lang:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_numeric_fallback should not warn code generated by external macros
5 participants