[master] Copy buffer only when format changes. #159
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| (kill-buffer)) | ||
| (progn | ||
| (if (not (string= (buffer-string) (with-current-buffer buf (buffer-string)))) | ||
| (progn (copy-to-buffer buf (point-min) (point-max)))) |
There was a problem hiding this comment.
I don't think it's necessary to use progn here anymore, since there's only one form inside the if's then-part.
|
@hotpxl Thanks! |
|
Hi. Just want to check on the status. Is there anything else I should do? |
|
LGTM :) |
In formatting code, only copies when
rustfmtactually changed something. This will save some meaningless "changed buffer" signs even if there is no change.