Skip to content

Use Eask for CI #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Use Eask for CI #444

merged 5 commits into from
Apr 28, 2022

Conversation

jcs090218
Copy link
Member

This patch does the following:

In .github/workflow/test.yml

  • Use jcs090218/setup-emacs instead of purcell/setup-emacs
    • Add retry capability to prevent failure on Emacs' installation
    • Support windows
  • Add setup-node (16)
  • Remove setup-cask (replace with setup-eask)
  • Add test for Emacs 28.1
  • Add tests on Windows and macOS

In Makefile

  • Replace Emacs command-line arguments emacs --batch ... with just eask <command>
  • Remove ELS variable, manage with Eask-file (use command eask files to list all package files)
  • Add make checkdoc and make lint but currently disabled, see error log here.
  • Add make build to test packaging and installing.
  • Replace make xxx-autoloads with just eask autoloads

Others

  • Eask-file added

This is totally optional, I think this would make CI a lot easier.

@brotzeit
Copy link
Contributor

brotzeit commented Apr 28, 2022

Thanks for the great work! cask has been a pain in the ass for quite some time. Did you already announce the package on reddit ?

@brotzeit brotzeit merged commit d17be30 into rust-lang:master Apr 28, 2022
@jcs090218
Copy link
Member Author

Thanks! :)

No, I haven't announced the package anywhere. This isn't a standard package so it will not be published to MELPA like Cask and Eldev. :(

But feel free to announce the tool anywhere if you like it! 😄

@brotzeit
Copy link
Contributor

I just think there are many package maintainers who would be thankful to have a replacement for cask. But people will start using it for their packages when they see it's used for popular packages like lsp-mode.

@jcs090218
Copy link
Member Author

That's basically the goal for Eask; maybe an alternative or replacement to Cask. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants