Establish more-controlled environment for fill-paragraph tests. #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a macro `rust-test-with-standard-fill-settings` to bind all the variables that affect `fill-paragraph`, and use it around all calls to `fill-paragraph`. Some tests based on `rust-test-fill-paragraph` were failing for me because I set `sentence-end-double-space` to nil, so double spaces after periods in the test input were getting collapsed into single spaces.
brotzeit
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a macro
rust-test-with-standard-fill-settingsto bind all the variables that affectfill-paragraph, and use it around all calls tofill-paragraph.Some tests based on
rust-test-fill-paragraphwere failing for me because I setsentence-end-double-spaceto nil, so double spaces after periods in the test input were getting collapsed into single spaces.