-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
The function should accept feature strings that old LLVM might not support. Simplify the code using the same approach used by LLVMRustPrintTargetFeatures. Dummify the function for non 4.0 LLVM and update the tests accordingly.
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ all: default | |
$(RUSTC) --target x86_64-pc-windows-gnu --print cfg | grep x86_64 | ||
$(RUSTC) --target i686-pc-windows-msvc --print cfg | grep msvc | ||
$(RUSTC) --target i686-apple-darwin --print cfg | grep macos | ||
$(RUSTC) --target i686-unknown-linux-gnu --print cfg | grep sse2 | ||
$(RUSTC) --target i686-unknown-linux-gnu --print cfg | grep gnu | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
lu-zero
Author
Contributor
|
||
|
||
ifdef IS_WINDOWS | ||
default: | ||
|
I was unable to find the rationale behind this change. Did the changes to rustllvm regress this test?
This was intentionally designed to check for the correct detection of the SIMD functionality as explained in
#31709 (comment)