Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for Seek::seek_relative #117374

Closed
1 of 3 tasks
fintelia opened this issue Oct 30, 2023 · 5 comments · Fixed by #123817
Closed
1 of 3 tasks

Tracking Issue for Seek::seek_relative #117374

fintelia opened this issue Oct 30, 2023 · 5 comments · Fixed by #123817
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@fintelia
Copy link
Contributor

fintelia commented Oct 30, 2023

Feature gate: #![feature(seek_seek_relative)]

This is a tracking issue for adding an additional method on the std::io::Seek trait that can only seek relative to the current position and which doesn't return the stream position.

Public API

trait Seek {
    fn seek_relative(&mut self, offset: i64) -> Result<()>;
}

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html

@fintelia fintelia added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 30, 2023
@fintelia
Copy link
Contributor Author

Is this ready for a FCP?

@Amanieu
Copy link
Member

Amanieu commented Mar 30, 2024

@rfcbot fcp merge

This adds a seek_relative method to the Seek trait, which allows BufReader::seek_relative to be called from generic code over R: Seek + Read. This is an important optimization since BufReader::seek must always discard any currently buffered data.

@rfcbot
Copy link

rfcbot commented Mar 30, 2024

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 30, 2024
@rfcbot
Copy link

rfcbot commented Mar 30, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Mar 30, 2024
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 9, 2024
@rfcbot
Copy link

rfcbot commented Apr 9, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Apr 9, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 11, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 13, 2024
Stabilize `seek_seek_relative`

This PR stabilizes `seek_seek_relative`:

```rust
// std::io::Seek

trait Seek {
    fn seek_relative(&mut self, offset: i64) -> Result<()>;
}
```

<br>

Tracking issue: rust-lang#117374.
Implementation PR: rust-lang#116750.

FCPs already completed in the tracking issue.

Closes rust-lang#117374.

r? libs-api
@bors bors closed this as completed in b0cbd4e May 13, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 13, 2024
Rollup merge of rust-lang#123817 - slanterns:seek_relative, r=dtolnay

Stabilize `seek_seek_relative`

This PR stabilizes `seek_seek_relative`:

```rust
// std::io::Seek

trait Seek {
    fn seek_relative(&mut self, offset: i64) -> Result<()>;
}
```

<br>

Tracking issue: rust-lang#117374.
Implementation PR: rust-lang#116750.

FCPs already completed in the tracking issue.

Closes rust-lang#117374.

r? libs-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants