Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de-glob std #11983

Closed
brson opened this issue Feb 2, 2014 · 5 comments
Closed

de-glob std #11983

brson opened this issue Feb 2, 2014 · 5 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 2, 2014

Globs are feature-gated because they are buggy and cause very hard-to-diagnose errors. Refactoring std often involves an explosion of resolve errors rooted in globs, which makes it very hard to change std sometimes. Remove all the globs to avoid this problem.
@chromatic chromatic mentioned this issue Feb 3, 2014
Closed
@HildarTheDorf
Copy link

Does this still need some work? I am willing to take a look, but I'd need some help not having git blow up in my face.

@lpy lpy mentioned this issue Feb 12, 2014
Closed
@lpy
Copy link
Contributor

lpy commented Feb 12, 2014

I will update the pull request later.

@fhahn
Copy link
Contributor

fhahn commented Mar 23, 2014

I've started working on this issue. So far, I've de-globbed a couple of files but there are many more to go. I'll open a PR when I went through all files.

@z0w0
Copy link
Contributor

z0w0 commented May 13, 2014

Does this include just removing them from std, or also other core libraries like syntax where globs are used more liberally?

@alexcrichton alexcrichton mentioned this issue May 30, 2014
Closed
@mdinger mdinger mentioned this issue Aug 22, 2014
Closed
@mikedilger mikedilger mentioned this issue Oct 22, 2014
Closed
@aturon
Copy link
Member

aturon commented Oct 23, 2014

This is an old bug, and we are heading in the direction of stabilizing globs heading into 1.0. Closing.

@aturon aturon closed this as completed Oct 23, 2014
@rust-highfive rust-highfive mentioned this issue Oct 27, 2014
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#11983 - jhpratt:remove-rustc_deprecated, r=ln…
3d2d209 
…icola

Remove handling of `#[rustc_deprecated]`

This should be merged along with rust-lang#95960.

Because the attribute still exists in rustc, I've left the definition here. With that said, any use of it is an error, so I've removed any handling of `#[rustc_deprecated]`.
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 4, 2024
@bors
Auto merge of rust-lang#12563 - J-ZhengLi:issue11513, r=Alexendoo
e0e7ee1 
make sure checked type implements `Try` trait when linting [`question_mark`]

(indirectly) fixes: rust-lang#12412 and fixes: rust-lang#11983

---

changelog: make sure checked type implements `Try` trait when linting [`question_mark`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@brson @fhahn @z0w0 @aturon @lpy @HildarTheDorf