Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put "checks that detect UB" under their own flag below debug_assertions #122678

Closed
RalfJung opened this issue Mar 18, 2024 · 2 comments · Fixed by #123411
Closed

Put "checks that detect UB" under their own flag below debug_assertions #122678

RalfJung opened this issue Mar 18, 2024 · 2 comments · Fixed by #123411
Labels
A-CLI Area: Command-line interface (CLI) to the compiler C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

This tracks the implementation of rust-lang/compiler-team#725. See there for all the details.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 18, 2024
@Noratrieb Noratrieb added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. A-CLI Area: Command-line interface (CLI) to the compiler and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 18, 2024
@saethlin saethlin self-assigned this Apr 3, 2024
@saethlin saethlin linked a pull request Apr 7, 2024 that will close this issue
Put checks that detect UB under their own flag below debug_assertions #123411
Merged
@saethlin
Copy link
Member

saethlin commented Apr 7, 2024 •
edited
Loading

Quoting the linked MCP:

Initially it would be unstable as -Zub-checks, and cfg(ub_checks)

#123411 achieves this. The MCP describes a stable flag, and waiting for cfg(overflow_checks) to be stabilized. I do not intend to work on those, so I'm unassigning myself.

@saethlin saethlin removed their assignment Apr 7, 2024
@RalfJung
Copy link
Member Author

RalfJung commented Apr 8, 2024

Closing in favor of #123499.

@RalfJung RalfJung closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CLI Area: Command-line interface (CLI) to the compiler C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put checks that detect UB under their own flag below debug_assertions saethlin/rust
4 participants
@RalfJung @saethlin @rustbot @Noratrieb