Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python dependency #13239

Closed
netkgk opened this issue Apr 1, 2014 · 9 comments
Closed

Remove python dependency #13239

netkgk opened this issue Apr 1, 2014 · 9 comments

Comments

@netkgk
Copy link

netkgk commented Apr 1, 2014

Remove this:
python 2.6 or later (but not 3.x)
from dependency list
@lifthrasiir
Copy link
Contributor

We are already discussing about getting rid of Perl dependency (#12913). We would still need to depend on at least one scripting language for various purposes (/src/etc has plenty of them as an example).

@huonw
Copy link
Member

huonw commented Apr 1, 2014

Just to be clear: this issue is filed about moving from Python 2.x to Python 3.x, not removing the Python dependency completely, right?

@thestinger
Copy link
Contributor

AFAIK, the dependency on Python 2 is mostly from LLVM.

@brson
Copy link
Contributor

brson commented Apr 1, 2014

Our 2.x dependency is from LLVM; Rust itself used to be able to cope with 3.x, but LLVM (at least as of 1+ years ago) can not.

@brson
Copy link
Contributor

brson commented Apr 1, 2014

I'm also not clear on what this bug is about. If it's to move just to 3 without supporting 2, then I would need more persuading.

@netkgk
Copy link
Author

netkgk commented Apr 2, 2014

I'm not clear what python is needed for at all. If it's about build process, there's more appropriate tools for that. Make compiled programming language dependent on python looks stupid for me.

@lifthrasiir
Copy link
Contributor

@netkgk Python is being widely used for checking commits (e.g. /src/etc/licenseck.py), handling and making snapshots (for bootstrapping the compiler, e.g. /src/etc/snapshot.py), generating Rust codes (e.g. /src/etc/unicode.py) and so on. I think there are no "appropriate" tools for them, simply because they have to be custom-made for Rust (and LLVM, as others pointed out). Also please note that your Rust program wouldn't depend on Python in any way, unless you choose to do so.

@thestinger
Copy link
Contributor

The Python dependency is only a build dependency. If you're not building Rust yourself, and most people won't be, you don't need to have it installed. The only reason to build Rust yourself once there are a solid set of distribution packages and first-party builds in place would be if you want to contribute to the project.

@brson
Copy link
Contributor

brson commented Apr 3, 2014

Sounds like this is a misunderstanding about how Rust uses Python. Closing.

@brson brson closed this as completed Apr 3, 2014
notriddle pushed a commit to notriddle/rust that referenced this issue Sep 20, 2022
@bors
Auto merge of rust-lang#13239 - mdx97:mathew/fix-add-reference-for-ma…
932e63b 
…cros, r=Veykril

Fix add reference action on macros.

Before we were using the range of the corresponding expression node in the macro expanded file, which is obviously incorrect as we are setting the text in the original source.

For some reason, the test I added is failing and I haven't found a way to fix it. Does anyone know why `check_fix` wouldn't work with macros? Getting this error:

```text
thread 'handlers::type_mismatch::tests::test_add_reference_to_macro_call' panicked at 'no diagnostics', crates/ide-diagnostics/src/handlers/type_mismatch.rs:317:9
```

closes rust-lang#13219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brson @lifthrasiir @huonw @thestinger @netkgk