New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloaded assignment operators can leak memory #2581

Closed
eholk opened this Issue Jun 13, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@eholk
Contributor

eholk commented Jun 13, 2012

It seems to involve pointers... Here's a test case with several examples and non-examples.

impl methods<T: copy> for [T] {
    fn -(x: [T]/&) -> [T] {
        [x[0], x[0], x[0]]
    }

    fn foo(x: [T]/&) -> [T] {
        [x[0], x[0], x[0]]
    }
}

impl methods<T: copy> for ~T {
    fn +(rhs: ~T) -> ~T {
        rhs
    }
}

impl methods for ~int {
    fn -(rhs: ~int) -> ~int {
        ~(*self - *rhs)
    }
}

fn main() {
    // leaks
    let mut bar = [1, 2, 3];
    bar -= [3, 2, 1];
    bar -= [4, 5, 6];

    io::println(#fmt("%?", bar));

    // okay
    let mut bar = [1, 2, 3];
    bar = bar.foo([3, 2, 1]);
    bar = bar.foo([4, 5, 6]);

    io::println(#fmt("%?", bar));

    // okay
    let mut bar = [1, 2, 3];
    bar = bar - [3, 2, 1];
    bar = bar - [4, 5, 6];

    io::println(#fmt("%?", bar));

    // Leaks
    let mut bar = ~1;
    bar += ~2;
    bar += ~3;

    io:: println(#fmt("%?", bar));

    // Leaks
    let mut bar = ~1;
    bar -= ~2;
    bar -= ~3;

    io:: println(#fmt("%?", bar));
}
@eholk

This comment has been minimized.

Show comment
Hide comment
@eholk

eholk Jun 13, 2012

Contributor

This problem is also present with @int, but they show up as an unreclaimed object in the cycle collector.

Contributor

eholk commented Jun 13, 2012

This problem is also present with @int, but they show up as an unreclaimed object in the cycle collector.

@ghost ghost assigned eholk Jun 13, 2012

eholk added a commit to eholk/rust that referenced this issue Jun 13, 2012

eholk added a commit to eholk/rust that referenced this issue Jun 14, 2012

@eholk eholk closed this Jun 21, 2012

@eholk eholk removed their assignment Jun 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment