Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trans fails when monomorphizing code with user-defined index ops #2631

Closed
catamorphism opened this issue Jun 15, 2012 · 0 comments
Closed

trans fails when monomorphizing code with user-defined index ops #2631

catamorphism opened this issue Jun 15, 2012 · 0 comments
Labels
A-codegen Area: Code generation A-typesystem Area: The type system
Milestone
0.3

Comments

@catamorphism
Copy link
Contributor

Specifically, this manifested with indexing into a dvec. Not all of the code that was manipulating callee_ids was handling the expr_index case.

Already fixed it, about to check in a fix. Thanks to @erickt for the test case.
catamorphism added a commit that referenced this issue Jun 15, 2012
@catamorphism
Test case for #2631
210db7d
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 29, 2022
@bors
Auto merge of rust-lang#2631 - RalfJung:futex-wait-no-isolate, r=Ralf…
e729db1 
…Jung

Support timeouts with monotonic clocks even when isolation is enabled

With the deterministic monotonic clock support we now have, we can allow some synchronization primitives with timeouts even under isolation:
- Linux futex waiting (when set to the monotonic clock)
- pthread_cond_timedwait (when set to the monotonic clock)
- Windows WaitOnAddress

Unfortunately none of these exist on macOS -- the standard library always uses the system clock for timeouts on macOS, so that will still require `-Zmiri-disable-isolation`.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2631 - RalfJung:futex-wait-no-isolate, r=Ralf…
6bbf016 
…Jung

Support timeouts with monotonic clocks even when isolation is enabled

With the deterministic monotonic clock support we now have, we can allow some synchronization primitives with timeouts even under isolation:
- Linux futex waiting (when set to the monotonic clock)
- pthread_cond_timedwait (when set to the monotonic clock)
- Windows WaitOnAddress

Unfortunately none of these exist on macOS -- the standard library always uses the system clock for timeouts on macOS, so that will still require `-Zmiri-disable-isolation`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-typesystem Area: The type system
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
1 participant
@catamorphism