Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "resolve: Use NameBinding for local variables and generic parameters" #90130

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Revert "resolve: Use NameBinding for local variables and generic parameters" #90130

merged 1 commit into from
Oct 21, 2021

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Oct 21, 2021 •
edited

This reverts commit 6162529, that is, PR #89100.

Reverting per performance regression noted post-merge on that PR (#89100 (comment)).

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2021
@Mark-Simulacrum Mark-Simulacrum changed the title Revert "Auto merge of #89100 - petrochenkov:localbind, r=cjgillot" Revert "resolve: Use NameBinding for local variables and generic parameters" Oct 21, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 21, 2021
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Oct 21, 2021

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Oct 21, 2021

📌 Commit 7552af2 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2021
@bors
Copy link
Contributor

bors commented Oct 21, 2021

⌛ Testing commit 7552af2 with merge 547a6ff...

@bors
Copy link
Contributor

bors commented Oct 21, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 547a6ff to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2021
@bors bors merged commit 547a6ff into rust-lang:master Oct 21, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 21, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (547a6ff): comparison url.

Summary: This change led to very large relevant improvements 🎉 in compiler performance.

  • Very large improvement in instruction counts (up to -49.8% on incr-unchanged builds of style-servo)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Mark-Simulacrum @rust-highfive @oli-obk @bors @rust-timer @rustbot