Remove eval_always for inherent_impls.

[cjgillot]

Split off #86056
r? @ghost

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit c4d7beb with merge ba893d940eef5619b107590bf98863eed785ff57...

[bors]

☀️ Try build successful - checks-actions
Build commit: ba893d940eef5619b107590bf98863eed785ff57 (ba893d940eef5619b107590bf98863eed785ff57)

[rust-timer]

Queued ba893d940eef5619b107590bf98863eed785ff57 with parent 4961b10, future comparison URL.

[rust-timer]

Finished benchmarking commit (ba893d940eef5619b107590bf98863eed785ff57): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

• Very large improvement in instruction counts (up to -5.7% on incr-unchanged builds of stm32f4)
• Small regression in instruction counts (up to 0.2% on incr-full builds of stm32f4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[Aaron1011]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit c4d7beb with merge 572f7694c4d170cb3708606cefdf2ef464f7a389...

[bors]

☀️ Try build successful - checks-actions
Build commit: 572f7694c4d170cb3708606cefdf2ef464f7a389 (572f7694c4d170cb3708606cefdf2ef464f7a389)

[rust-timer]

Queued 572f7694c4d170cb3708606cefdf2ef464f7a389 with parent 883a241, future comparison URL.

[rust-timer]

Finished benchmarking commit (572f7694c4d170cb3708606cefdf2ef464f7a389): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

• Very large improvement in instruction counts (up to -5.6% on incr-unchanged builds of stm32f4)
• Small regression in instruction counts (up to 0.2% on incr-full builds of stm32f4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[Aaron1011]

@bors r+

[bors]

📌 Commit c4d7beb has been approved by Aaron1011

[bors]

⌛ Testing commit c4d7beb with merge 4dcc252ea1b1016fd55fb2ad5a94fb5b5795de05...

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

......... (50/53)
...        (53/53)


/checkout/src/test/rustdoc-gui/toggle-click-deadspace.goml toggle-click-deadspace... FAILED
[ERROR] (line 8) Error: Evaluation failed: assert didn't fail: for command `assert-attribute-false: (".impl-items .rustdoc-toggle", {"open": ""})`



command did not execute successfully: "/node-v14.4.0-linux-x64/bin/node" "/checkout/src/tools/rustdoc-gui/tester.js" "--jobs" "16" "--doc-folder" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc" "--tests-folder" "/checkout/src/test/rustdoc-gui"


Build completed unsuccessfully in 0:00:18

[bors]

💔 Test failed - checks-actions

[Aaron1011]

@bors retry

[bors]

⌛ Testing commit c4d7beb with merge c6a7ca1...

[bors]

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing c6a7ca1 to master...

[rust-timer]

Finished benchmarking commit (c6a7ca1): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

• Very large improvement in instruction counts (up to -5.6% on incr-unchanged builds of stm32f4)
• Small regression in instruction counts (up to 0.2% on incr-full builds of stm32f4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression