Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cc version in bootstrap #100117

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Conversation

nicholasbishop
Copy link
Contributor

Among other changes, the newer cc release pulls in this fix:
rust-lang/cc-rs@b2792e3

This fixes errors when building compiler_builtins for UEFI targets.

Among other changes, the newer cc release pulls in this fix:
rust-lang/cc-rs@b2792e3

This fixes errors when building compiler_builtins for UEFI targets.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 6, 2022

📌 Commit 34537b4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2022
@bors
Copy link
Contributor

bors commented Aug 6, 2022

⌛ Testing commit 34537b4 with merge 2befdef...

@bors
Copy link
Contributor

bors commented Aug 6, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 2befdef to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2022
@bors bors merged commit 2befdef into rust-lang:master Aug 6, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 6, 2022
@nicholasbishop nicholasbishop deleted the bishop-update-cc branch August 7, 2022 00:22
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2befdef): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-0.9% -1.0% 3
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-3.5% -3.5% 1
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants