Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest adding a missing semicolon before an item #100565

Merged

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Aug 15, 2022

fixes #100533

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 15, 2022
@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2022
@compiler-errors
Copy link
Member

r? @compiler-errors

r=me with question answered

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Aug 21, 2022

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Aug 21, 2022

📌 Commit 40dcf89 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 23, 2022
…icolon-before-item, r=compiler-errors

Suggest adding a missing semicolon before an item

fixes rust-lang#100533
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100382 (Make the GATS self outlives error take into GATs in the inputs)
 - rust-lang#100565 (Suggest adding a missing semicolon before an item)
 - rust-lang#100641 (Add the armv4t-none-eabi target to the supported_targets)
 - rust-lang#100789 (Use separate infcx to solve obligations during negative coherence)
 - rust-lang#100832 (Some small bootstrap cleanup)
 - rust-lang#100861 (fix ICE with extra-const-ub-checks)
 - rust-lang#100862 (tidy: remove crossbeam-utils)
 - rust-lang#100887 (Refactor part of codegen_call_terminator)
 - rust-lang#100893 (Remove out-of-context comment in `mem::MaybeUninit` documentation)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54d0f50 into rust-lang:master Aug 23, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 23, 2022
@TaKO8Ki TaKO8Ki deleted the suggest-adding-missing-semicolon-before-item branch August 23, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing semicolon suggestion for global variable declarations
6 participants