Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler/rustc_codegen_ssa/src/mir/place.rs: Remove LLVM bug workaround #100958

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

mikebenfield
Copy link
Contributor

This memset was inserted as a workaround to Rust issue #34427, which was
an LLVM bug that apparently no longer manifests.

@rust-highfive
Copy link
Collaborator

r? @TaKO8Ki

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2022
This memset was inserted as a workaround to Rust issue rust-lang#34427, which was
an LLVM bug that apparently no longer manifests.
@RalfJung
Copy link
Member

Cc @nikic

@mikebenfield
Copy link
Contributor Author

FWIW, I've verified that on an aarch64-unknown-linux-gnu machine, both ./x.py test --stage 1 and ./x.py test --stage 2 pass with this commit.

@cuviper
Copy link
Member

cuviper commented Aug 25, 2022

Would you be able to try a 32-bit ARM toolchain as well?
(AArch64 and ARM are separate targets in LLVM.)

@mikebenfield
Copy link
Contributor Author

Unfortunately I won't have access to an arm (not aarch64) machine in the immediate future. Worst case scenario it'll be tested on an arm machine before merge right?

@cuviper
Copy link
Member

cuviper commented Aug 25, 2022

We don't have a 32-bit arm machine in CI, but we do test arm-android, cross-compiled and executed in qemu.

@RalfJung
Copy link
Member

This is effectively a revert of #36496, so also Cc @pnkfelix

@cuviper
Copy link
Member

cuviper commented Aug 27, 2022

I found a Fedora community machine to try armv7-unknown-linux-gnueabihf, and it looks good there as well.

@nikic
Copy link
Contributor

nikic commented Aug 28, 2022

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Aug 28, 2022

📌 Commit 12a9914 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2022
@bors
Copy link
Contributor

bors commented Sep 1, 2022

⌛ Testing commit 12a9914 with merge 4f9898a...

@bors
Copy link
Contributor

bors commented Sep 1, 2022

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 4f9898a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2022
@bors bors merged commit 4f9898a into rust-lang:master Sep 1, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 1, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4f9898a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
5.3% [5.3%, 5.3%] 1
Regressions ❌
(secondary)
2.6% [2.1%, 3.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.8% [-6.8%, -6.8%] 1
All ❌✅ (primary) 5.3% [5.3%, 5.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants