-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the way libunwind is linked for *-windows-gnullvm targets #103894
Conversation
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
abfd414
to
6507460
Compare
This fixes unwinding on `aarch64-*-windows-gnu*`.
6507460
to
7333ee0
Compare
This looks fine to me. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (7b513af): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
…ark-Simulacrum Fix building of `aarch64-pc-windows-gnullvm` That change had been lost during rebase of my last PR (rust-lang#103894).
…md64, r=thomcc Reduce exceptions overallocation on non Windows x86_64 Addressing rust-lang#103894 (comment)
…=thomcc Change the way libunwind is linked for *-windows-gnullvm targets I have no idea why previous way works for `x86_64-fortanix-unknown-sgx` (assuming it actually works...) but not for `gnullvm`. It fails when linking libtest during Rust build (unless somebody adds `RUSTFLAGS='-Clinkarg=-lunwind'`). Also fixes exception handling on AArch64.
…acrum Fix building of `aarch64-pc-windows-gnullvm` That change had been lost during rebase of my last PR (rust-lang/rust#103894).
…homcc Reduce exceptions overallocation on non Windows x86_64 Addressing rust-lang/rust#103894 (comment)
I have no idea why previous way works for
x86_64-fortanix-unknown-sgx
(assuming it actually works...) but not forgnullvm
. It fails when linking libtest during Rust build (unless somebody addsRUSTFLAGS='-Clinkarg=-lunwind'
).Also fixes exception handling on AArch64.