Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_metadata: Split children into multiple tables #110333

Merged
merged 1 commit into from
Apr 21, 2023
Merged

rustc_metadata: Split children into multiple tables #110333

merged 1 commit into from
Apr 21, 2023

Conversation

petrochenkov
Copy link
Contributor

instead of merging everything into a single bag.

If it's acceptable from performance point of view, then it's more clear to keep this stuff organized more in accordance with its use.

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 14, 2023
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 14, 2023
@bors
Copy link
Contributor

bors commented Apr 14, 2023

⌛ Trying commit fac58797e3f5bbf6130e9467f4b23797a7837d4d with merge 17771203d49e1766373acad1b44f2afc0b25375e...

@bors
Copy link
Contributor

bors commented Apr 14, 2023

☀️ Try build successful - checks-actions
Build commit: 17771203d49e1766373acad1b44f2afc0b25375e (17771203d49e1766373acad1b44f2afc0b25375e)

@rust-timer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (17771203d49e1766373acad1b44f2afc0b25375e): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.8% [2.8%, 4.9%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.9% [-3.9%, -3.9%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 15, 2023
@Kobzol
Copy link
Contributor

Kobzol commented Apr 16, 2023 •
edited
Loading

https://perf.rust-lang.org/compare.html?start=276fa294809e914b1d04192392d256814aa5ce1a&end=17771203d49e1766373acad1b44f2afc0b25375e&stat=size%3Acrate_metadata Metadata size has regressed somewhat (expectedly). I wonder why binary size has also increased 🤔.

@petrochenkov petrochenkov changed the title [WIP] rustc_metadata: Split children into multiple tables rustc_metadata: Split children into multiple tables Apr 17, 2023
@petrochenkov
Copy link
Contributor Author

Metadata size has regressed somewhat (expectedly).

Ok, that's not very good.
I merged associated item def ids and field def ids back into a single table, the difference is purely cosmetic in that case.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 17, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor Author

undefined reference to `std::io::error::Error::_new'

What.
This shouldn't be related to this PR at all.

compiler-errors
compiler-errors approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me unless you want to do a force-push or something to verify that error is unrelated to the PR.

@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2023
@petrochenkov
Copy link
Contributor Author

@bors r=compiler-errors rollup=maybe

@bors
Copy link
Contributor

bors commented Apr 19, 2023

📌 Commit c7174a73d698b20849e605838a1f4db74a656475 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2023
@bors
Copy link
Contributor

bors commented Apr 19, 2023

⌛ Testing commit c7174a73d698b20849e605838a1f4db74a656475 with merge 58e1e837cc5f356fadedaa7ea48b6e29d5dbeca9...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2023
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2023
@petrochenkov
rustc_metadata: Split children into multiple tables
cbc6ccb 
instead of merging everything into a single bag.

If it's acceptable from performance point of view, then it's more clear to keep this stuff organized more in accordance with its use.
@petrochenkov
Copy link
Contributor Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Apr 21, 2023

📌 Commit cbc6ccb has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 21, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2023
@bors
Auto merge of rust-lang#110648 - Dylan-DPC:rollup-em3ovcq, r=Dylan-DPC
fec9adc 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#110333 (rustc_metadata: Split `children` into multiple tables)
 - rust-lang#110501 (rustdoc: fix ICE from rustc_resolve and librustdoc parse divergence)
 - rust-lang#110608 (Specialize some `io::Read` and `io::Write` methods for `VecDeque<u8>` and `&[u8]`)
 - rust-lang#110632 (Panic instead of truncating if the incremental on-disk cache is too big)
 - rust-lang#110633 (More `mem::take` in `library`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ff4a5fb into rust-lang:master Apr 21, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
7 participants
@petrochenkov @rustbot @rust-timer @bors @Kobzol @rust-log-analyzer @compiler-errors