Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #116077

Merged
merged 16 commits into from
Sep 22, 2023
Merged

Rollup of 6 pull requests #116077

merged 16 commits into from
Sep 22, 2023

Commits on Sep 12, 2023

  1. match on elem first

    ouz-a committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    22b1acb View commit details
    Browse the repository at this point in the history
  2. very verbose error handling

    ouz-a committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0cb22a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. remove inner match

    ouz-a committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d6efedc View commit details
    Browse the repository at this point in the history
  2. better bug message

    ouz-a committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    442c87a View commit details
    Browse the repository at this point in the history
  3. Capture scrutinee of if let guards correctly

    Previously we were always capturing by value.
    matthewjasper committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d4ffb3b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    63df126 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8e06b25 View commit details
    Browse the repository at this point in the history
  6. Change start to #[start] in some diagnosis

    They refer to a function with the `start` attribute, but not necessarily named `start`.
    eduardosm committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    17dfabf View commit details
    Browse the repository at this point in the history
  7. make unsized cast illegal

    ouz-a committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    861448b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    09960e0 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#115770 - ouz-a:match_elem_builder, r=lcnr

    Match on elem first while building move paths
    
    While working on rust-lang#115025 `@lcnr` and I observed "move_paths_for" function matched on the `Ty` instead of `Projection` which seems flawed as it's the `Projection`s that cause the problem not the type.
    
    r? `@lcnr`
    matthiaskrgr committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d4d0c84 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#115999 - matthewjasper:closure-capture-let-…

    …guards, r=b-naber
    
    Capture scrutinee of if let guards correctly
    
    Previously we were always capturing by value.
    
    cc rust-lang#51114
    matthiaskrgr committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e6f4b35 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#116056 - ouz-a:wide_ice, r=compiler-errors

    Make unsized casts illegal
    
    Weirdly enough this rust-lang#115998 issue seems to exist since Rust 1.0 (couldn't check before that) but it's only recently been noticed. This change makes those casts illegal.
    
    Fixes rust-lang#115998
    matthiaskrgr committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a38f230 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#116061 - Nilstrieb:Nilstrieb-patch-1, r=TaK…

    …O8Ki
    
    Remove TaKO8Ki from review rotation
    
    `@TaKO8Ki` you haven't been actively reviewing pull requests lately, so I'm removing you from the rotation. Thank you for all the PRs you have reviewed when you were more actively, it was very helpful! Feel free to add yourself back when you have more time 💜
    
    r? `@wesleywiser` `@davidtwco`
    matthiaskrgr committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    81b98f6 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#116062 - eduardosm:start-fn-diag, r=WaffleL…

    …apkin
    
    Change `start` to `#[start]` in some diagnosis
    
    They refer to a function with the `start` attribute, but not necessarily named `start`.
    matthiaskrgr committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    952d660 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#116067 - saethlin:meta-stats-ice, r=WaffleL…

    …apkin
    
    Open the FileEncoder file for reading and writing
    
    Maybe I just don't know `File` well enough, but the previous comment didn't make it clear enough to me that we can't use `File::create`. This one does.
    
    Fixes rust-lang#116055
    
    r? `@WaffleLapkin`
    matthiaskrgr committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    efee13a View commit details
    Browse the repository at this point in the history