Make ConstPropLint lint run on promoteds

[gurry]

Fixes #117949 wherein the lint didn't fire for the following promoteds:

• SHL or SHR operators in a non-optimized build
• any arithmetic operator in an optimized build

What I have done here is simply enabled ConstPropLint to run on promoted bodies by removing the relevant if check.

After this change all promoted arithmetic operators will lint in both non-optimized and optimized builds. On the flip side programs containing the above mentioned overflowing promoteds that were accepted earlier will now be rejected. Hope that is okay from a backward compatibility standpoint.

I have added tests covering all overflowing promoted & non-promoted ops for both compile-time and runtime operations and for optimized as well as non-optimized builds.

I had to amend some existing tests to make them pass and had to delete a couple that were set to pass despite overflows.

This PR increases the number of duplicate diagnostics emitted (because the same operator might get linted in both the promoted MIR and the main MIR). I hope that is an acceptable trade-off given that we now lint overflows much more comprehensively than earlier.

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[gurry]

@rustbot author

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

[gurry]

@rustbot review

[compiler-errors]

@rustbot author

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit ecadc52 with merge 8a1050b...

[gurry]

@rustbot review

[RalfJung]

@bors r=oli-obk

[bors]

📌 Commit 9e27a7e has been approved by oli-obk

It is now in the queue for this repository.

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout 117949-make-lint-run-on-promoteds (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self 117949-make-lint-run-on-promoteds --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

CONFLICT (modify/delete): tests/ui/numbers-arithmetic/promoted_overflow_opt.rs deleted in heads/homu-tmp and modified in HEAD. Version HEAD of tests/ui/numbers-arithmetic/promoted_overflow_opt.rs left in tree.
CONFLICT (modify/delete): tests/ui/lint/lint-exceeding-bitshifts.rs deleted in heads/homu-tmp and modified in HEAD. Version HEAD of tests/ui/lint/lint-exceeding-bitshifts.rs left in tree.
Removing tests/ui/lint/lint-exceeding-bitshifts.opt_with_overflow_checks.stderr
Removing tests/ui/lint/lint-exceeding-bitshifts.opt.stderr
Removing tests/ui/lint/lint-exceeding-bitshifts.noopt.stderr
Auto-merging tests/ui/consts/promotion.rs
Auto-merging tests/ui/consts/const-eval/issue-50814.rs
CONFLICT (modify/delete): tests/ui/consts/const-err2.rs deleted in heads/homu-tmp and modified in HEAD. Version HEAD of tests/ui/consts/const-err2.rs left in tree.
Removing tests/ui/consts/const-err2.opt_with_overflow_checks.stderr
Removing tests/ui/consts/const-err2.opt.stderr
Removing tests/ui/consts/const-err2.noopt.stderr
Automatic merge failed; fix conflicts and then commit the result.

[bors]

☔ The latest upstream changes (presumably #120881) made this pull request unmergeable. Please resolve the merge conflicts.

[gurry]

Let me rebase

[oli-obk]

@bors r+

[bors]

📌 Commit 5010ca0 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5010ca0 with merge dfdbe30...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing dfdbe30 to master...

[rust-timer]

Finished benchmarking commit (dfdbe30): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-2.4%, -1.1%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 639.28s -> 639.52s (0.04%)
Artifact size: 306.36 MiB -> 306.35 MiB (-0.00%)