Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Apple target_abi #124762

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented May 5, 2024

This was bundled together with Arch, which complicated a few code paths and meant we had to do more string matching than necessary.

CC @BlackHoleFox as you've worked on the Apple target spec before

Related: Is there a reason why Target/TargetOptions use StaticCow for so many things, instead of an enum with defined values (and perhaps a catch-all case for custom target json files)? Tagging @Nilstrieb, as you might know?

This was bundled together with `Arch`, which complicated a few code
paths and meant we had to do more string matching than necessary.
@rustbot
Copy link
Collaborator

rustbot commented May 5, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 5, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@lcnr
Copy link
Contributor

lcnr commented May 6, 2024

looking through this, pretty certain that this doesn't do any functional changes (so r=me on that front). Unsure whether this split is generally desirable/the state of apple abis more generally

r? compiler

@rustbot rustbot assigned pnkfelix and unassigned lcnr May 6, 2024
Copy link
Contributor

@BlackHoleFox BlackHoleFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a t-compiler member but just as someone who works on these files a lot this is an improvement in many ways. Especially the removal of macabi being hardcoded in too many places.

@Noratrieb
Copy link
Member

lcnr says there are no functional changes, BlackHoleFox thinks this is an improvement, that sounds good.
@bors r=lcnr,BlackHoleFox

@bors
Copy link
Contributor

bors commented May 11, 2024

📌 Commit 8f0d357 has been approved by lcnr,BlackHoleFox

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@bors
Copy link
Contributor

bors commented May 11, 2024

⌛ Testing commit 8f0d357 with merge 2259028...

@bors
Copy link
Contributor

bors commented May 11, 2024

☀️ Test successful - checks-actions
Approved by: lcnr,BlackHoleFox
Pushing 2259028 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2024
@bors bors merged commit 2259028 into rust-lang:master May 11, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2259028): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.209s -> 673.288s (-0.28%)
Artifact size: 315.95 MiB -> 316.02 MiB (0.02%)

@madsmtm madsmtm deleted the refactor-apple-target-abi branch May 11, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants