Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostic output of non_local_definitions lint #125089

Merged
merged 11 commits into from
May 28, 2024
Merged

Improve diagnostic output of non_local_definitions lint #125089

merged 11 commits into from
May 28, 2024

Commits on May 27, 2024

  1. non_local_defs: move out from #[derive(LintDiagnostic)] to manual impl

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5ad4ad7 View commit details
    Browse the repository at this point in the history

  2. non_local_defs: switch to more friendly primary message

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    06c6a2d View commit details
    Browse the repository at this point in the history

  3. non_local_defs: improve some notes around trait, bounds, consts 

     - Restrict const-anon exception diag to relevant places
 - Invoke bounds (and type-inference) in non_local_defs
 - Specialize diagnostic for impl without Trait
    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    de1c122 View commit details
    Browse the repository at this point in the history

  4. non_local_defs: use span of the impl def and not the impl block

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    26b873d View commit details
    Browse the repository at this point in the history

  5. non_local_defs: use labels to indicate what may need to be moved

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    22095fb View commit details
    Browse the repository at this point in the history

  6. non_local_defs: improve exception note for impl and macro_rules! 

     - Remove wrong exception text for non-local macro_rules!
 - Simplify anonymous const exception note
    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    402580b View commit details
    Browse the repository at this point in the history

  7. non_local_defs: be more precise about what needs to be moved

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d3dfe14 View commit details
    Browse the repository at this point in the history

  8. non_local_defs: improve main without a trait note

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ab23fd8 View commit details
    Browse the repository at this point in the history

  9. non_local_defs: suggest removing leading ref/ptr to make the impl local

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    b719529 View commit details
    Browse the repository at this point in the history

  10. non_local_defs: point to Self and Trait to give more context

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    98273ec View commit details
    Browse the repository at this point in the history

  11. non_local_defs: point the parent item when appropriate

    @Urgau
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c7d3004 View commit details
    Browse the repository at this point in the history