Uplift `Binder`, `OutlivesPredicate` into `rustc_type_ir` #125335

compiler-errors · 2024-05-20T17:58:44Z

Almost done with all the types 🙏

r? lcnr

rustbot · 2024-05-21T14:22:27Z

HIR ty lowering was modified

cc @fmease

compiler/rustc_type_ir/src/binder.rs

compiler/rustc_type_ir/src/predicate.rs

lcnr

r=me after nits

compiler/rustc_type_ir/src/predicate.rs

compiler-errors · 2024-05-21T17:22:36Z

@bors r=lcnr rollup=never

bors · 2024-05-21T17:22:39Z

📌 Commit 09c585d has been approved by lcnr

It is now in the queue for this repository.

jackh726 · 2024-05-21T19:53:51Z

compiler/rustc_middle/src/ty/predicate.rs

+pub type PolyTypeOutlivesPredicate<'tcx> = ty::Binder<'tcx, TypeOutlivesPredicate<'tcx>>;
+pub type PolySubtypePredicate<'tcx> = ty::Binder<'tcx, SubtypePredicate<'tcx>>;
+pub type PolyCoercePredicate<'tcx> = ty::Binder<'tcx, CoercePredicate<'tcx>>;
+pub type PolyProjectionPredicate<'tcx> = Binder<'tcx, ProjectionPredicate<'tcx>>;


ty::Binder?

compiler-errors · 2024-05-21T19:58:46Z

@bors r=lcnr

bors · 2024-05-21T19:58:48Z

📌 Commit aec9ae3 has been approved by lcnr

It is now in the queue for this repository.

compiler-errors · 2024-05-21T20:01:06Z

@bors r=lcnr

bors · 2024-05-21T20:01:08Z

📌 Commit 8eee352 has been approved by lcnr

It is now in the queue for this repository.

compiler-errors · 2024-05-21T20:06:53Z

@bors r-

…pes from Interner

compiler-errors · 2024-05-21T21:15:06Z

@bors r=lcnr

bors · 2024-05-21T21:15:08Z

📌 Commit 1c8230e has been approved by lcnr

It is now in the queue for this repository.

Uplift `Binder`, `OutlivesPredicate` into `rustc_type_ir` Almost done with all the types 🙏 r? lcnr

bors · 2024-05-22T07:29:10Z

⌛ Testing commit 1c8230e with merge 12ae14f...

rust-log-analyzer · 2024-05-22T08:25:46Z

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] either test:false 0.505
[RUSTC-TIMING] build_script_build test:false 0.461
[RUSTC-TIMING] heck test:false 0.403
   Compiling limit v0.0.0 (/checkout/src/tools/rust-analyzer/crates/limit)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
   Compiling countme v3.0.1
[RUSTC-TIMING] limit test:false 0.105
   Compiling semver v1.0.23
[RUSTC-TIMING] build_script_build test:false 0.505
[RUSTC-TIMING] build_script_build test:false 0.505
[RUSTC-TIMING] smallvec test:false 0.582
   Compiling serde_json v1.0.117

Session terminated, killing shell...::group::Clock drift check
  network time:    Compiling itoa v1.0.11
   Compiling ryu v1.0.18
 ...killed.
##[error]The operation was canceled.

bors · 2024-05-22T08:26:27Z

💔 Test failed - checks-actions

fmease · 2024-05-22T08:32:21Z

@bors retry

bors · 2024-05-22T08:33:38Z

⌛ Testing commit 1c8230e with merge bec1029...

bors · 2024-05-22T10:50:57Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing bec1029 to master...

rust-timer · 2024-05-22T12:06:45Z

Finished benchmarking commit (bec1029): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.666s -> 671.163s (-0.22%)
Artifact size: 315.47 MiB -> 316.18 MiB (0.23%)

rustbot assigned lcnr May 20, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 20, 2024

This comment has been minimized.

Sign in to view

compiler-errors force-pushed the binder branch 2 times, most recently from 633a0c6 to bea8fd9 Compare May 21, 2024 14:13

compiler-errors marked this pull request as ready for review May 21, 2024 14:22

compiler-errors changed the title ~~Uplift Binder into rustc_type_ir~~ Uplift Binder, OutlivesPredicate into rustc_type_ir May 21, 2024

lcnr reviewed May 21, 2024

View reviewed changes

compiler/rustc_type_ir/src/binder.rs Show resolved Hide resolved

lcnr reviewed May 21, 2024

View reviewed changes

compiler/rustc_type_ir/src/predicate.rs Outdated Show resolved Hide resolved

lcnr reviewed May 21, 2024

View reviewed changes

compiler-errors force-pushed the binder branch from 818996d to ca9e2f4 Compare May 21, 2024 16:54

This comment has been minimized.

Sign in to view

compiler-errors force-pushed the binder branch from ca9e2f4 to b5bdccd Compare May 21, 2024 17:02

lcnr reviewed May 21, 2024

View reviewed changes

compiler/rustc_type_ir/src/predicate.rs Outdated Show resolved Hide resolved

compiler-errors force-pushed the binder branch from b5bdccd to 09c585d Compare May 21, 2024 17:22

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2024

jackh726 reviewed May 21, 2024

View reviewed changes

compiler-errors force-pushed the binder branch from 09c585d to aec9ae3 Compare May 21, 2024 19:58

compiler-errors force-pushed the binder branch from aec9ae3 to 8eee352 Compare May 21, 2024 20:00

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 21, 2024

compiler-errors added 2 commits May 21, 2024 17:00

Uplift binder

28ce588

Uplift OutlivesPredicate, remove a bunch of unnecessary associated ty…

1c8230e

…pes from Interner

compiler-errors force-pushed the binder branch from 8eee352 to 1c8230e Compare May 21, 2024 21:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2024

Auto merge of rust-lang#125335 - compiler-errors:binder, r=lcnr

12ae14f

Uplift `Binder`, `OutlivesPredicate` into `rustc_type_ir` Almost done with all the types 🙏 r? lcnr

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 22, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label May 22, 2024

bors merged commit bec1029 into rust-lang:master May 22, 2024
7 checks passed

rustbot added this to the 1.80.0 milestone May 22, 2024

bors mentioned this pull request May 22, 2024

Implement needs_async_drop in rustc and optimize async drop glue #124662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uplift `Binder`, `OutlivesPredicate` into `rustc_type_ir` #125335

Uplift `Binder`, `OutlivesPredicate` into `rustc_type_ir` #125335

compiler-errors commented May 20, 2024

This comment has been minimized.

rustbot commented May 21, 2024

lcnr left a comment

This comment has been minimized.

compiler-errors commented May 21, 2024

bors commented May 21, 2024

jackh726 May 21, 2024

compiler-errors commented May 21, 2024

bors commented May 21, 2024

compiler-errors commented May 21, 2024

bors commented May 21, 2024

This comment has been minimized.

compiler-errors commented May 21, 2024

compiler-errors commented May 21, 2024

bors commented May 21, 2024

bors commented May 22, 2024

rust-log-analyzer commented May 22, 2024

bors commented May 22, 2024

fmease commented May 22, 2024

bors commented May 22, 2024

bors commented May 22, 2024

rust-timer commented May 22, 2024

Uplift Binder, OutlivesPredicate into rustc_type_ir #125335

Uplift Binder, OutlivesPredicate into rustc_type_ir #125335

Conversation

compiler-errors commented May 20, 2024

This comment has been minimized.

rustbot commented May 21, 2024

lcnr left a comment

Choose a reason for hiding this comment

This comment has been minimized.

compiler-errors commented May 21, 2024

bors commented May 21, 2024

jackh726 May 21, 2024

Choose a reason for hiding this comment

compiler-errors commented May 21, 2024

bors commented May 21, 2024

compiler-errors commented May 21, 2024

bors commented May 21, 2024

This comment has been minimized.

compiler-errors commented May 21, 2024

compiler-errors commented May 21, 2024

bors commented May 21, 2024

bors commented May 22, 2024

rust-log-analyzer commented May 22, 2024

bors commented May 22, 2024

fmease commented May 22, 2024

bors commented May 22, 2024

bors commented May 22, 2024

rust-timer commented May 22, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uplift `Binder`, `OutlivesPredicate` into `rustc_type_ir` #125335

Uplift `Binder`, `OutlivesPredicate` into `rustc_type_ir` #125335