Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mixed_integer_ops_unsigned_sub #126046

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement mixed_integer_ops_unsigned_sub #126046

wants to merge 1 commit into from

Conversation

davidzeng0
Copy link
Contributor

@davidzeng0 davidzeng0 commented Jun 5, 2024 •
edited by Dylan-DPC
Loading

Implement #126043

ACP: rust-lang/libs-team#386 [Accepted]

@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 5, 2024
@davidzeng0 davidzeng0 mentioned this pull request Jun 5, 2024
Open
4 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@davidzeng0 davidzeng0 force-pushed the mixed_integer_ops_unsigned_sub branch from a51d03b to cdb1452 Compare June 5, 2024 21:03
@bors
Copy link
Contributor

bors commented Jul 25, 2024

☔ The latest upstream changes (presumably #128155) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) O-hermit Operating System: Hermit O-ios Operating system: iOS O-itron Operating System: ITRON O-linux Operating system: Linux O-macos Operating system: macOS O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows PG-exploit-mitigations Project group: Exploit mitigations T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jul 25, 2024
@rustbot rustbot added T-style Relevant to the style team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 25, 2024
@davidzeng0 davidzeng0 force-pushed the mixed_integer_ops_unsigned_sub branch from 31cbaee to 6a5a88e Compare July 25, 2024 02:08
@Dylan-DPC Dylan-DPC added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows O-linux Operating system: Linux O-macos Operating system: macOS O-ios Operating system: iOS T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. A-meta Area: Issues & PRs about the rust-lang/rust repository itself O-SGX Target: SGX A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) O-unix Operating system: Unix-like A-rustdoc-json Area: Rustdoc JSON backend A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-style Relevant to the style team, which will review and decide on the PR/issue. PG-exploit-mitigations Project group: Exploit mitigations WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) O-wasi Operating system: Wasi, Webassembly System Interface O-hermit Operating System: Hermit O-itron Operating System: ITRON O-solid Operating System: SOLID O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) A-run-make Area: port run-make Makefiles to rmake.rs T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidzeng0 @rustbot @rust-log-analyzer @bors @m-ou-se @Dylan-DPC