deprecate -Csoft-float because it is unsound (and not fixable) #129897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
RalfJung
force-pushed
the
soft-float-ignored
branch
from
8e55395
to
ab54f40
Compare
Dirbaio
approved these changes
Sep 2, 2024
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
soft-float-ignored
branch
from
ab54f40
to
45ddafa
Compare
Urgau
reviewed
Sep 2, 2024
RalfJung
force-pushed
the
soft-float-ignored
branch
from
45ddafa
to
bf70656
Compare
RalfJung
changed the title
RalfJung
force-pushed
the
soft-float-ignored
branch
from
bf70656
to
f2c4e12
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
soft-float-ignored
branch
from
f2c4e12
to
2ca3496
Compare
Urgau
reviewed
Sep 3, 2024
RalfJung
force-pushed
the
soft-float-ignored
branch
from
2ca3496
to
aa81837
Compare
RalfJung
force-pushed
the
soft-float-ignored
branch
from
aa81837
to
914d8f4
Compare
|
I have changed what the PR does so it now marks |
3 tasks
|
MCP for this: rust-lang/compiler-team#779. |
Urgau
added
S-waiting-on-MCP
Urgau
added
S-waiting-on-review
Urgau
approved these changes
Sep 15, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#129897 (deprecate -Csoft-float because it is unsound (and not fixable)) - rust-lang#130339 (Add `core::panic::abort_unwind`) - rust-lang#130384 (compiler: Document AbiAndPrefAlign) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
Rollup merge of rust-lang#129897 - RalfJung:soft-float-ignored, r=Urgau deprecate -Csoft-float because it is unsound (and not fixable) See rust-lang#129893 for details. The general sentiment there seems to be that this flag has no use and sound alternatives exist, so let's add this warning and see if anyone out there disagrees. Also show a different warning on targets where it does nothing (as documented since rust-lang#36261): it seems to correspond to `-mfloat-abi` in GCC/clang, which is an ARM-specific option. To be really sure it does nothing, only forward the flag to LLVM for eabihf targets. This should not change behavior but makes me sleep better ;)
RalfJung
added
the
relnotes
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #129893 for details. The general sentiment there seems to be that this flag has no use and sound alternatives exist, so let's add this warning and see if anyone out there disagrees.
Also show a different warning on targets where it does nothing (as documented since #36261): it seems to correspond to
-mfloat-abiin GCC/clang, which is an ARM-specific option. To be really sure it does nothing, only forward the flag to LLVM for eabihf targets. This should not change behavior but makes me sleep better ;)