Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Drop Total from Total{Eq,Ord} #14579

Merged
merged 1 commit into from
Jun 1, 2014

Conversation

alexcrichton
Copy link
Member

This completes the last stage of the renaming of the comparison hierarchy of
traits. This change renames TotalEq to Eq and TotalOrd to Ord.

In the future the new Eq/Ord will be filled out with their appropriate methods,
but for now this change is purely a renaming change.

This continues the work of #12517, continuing the work in #14534. This patch accomplishes the final rename of TotalEq to TotalOrd. I wanted to get this patch landed ASAP so we don't have to deal much with "where did Eq and Ord go?"

I have yet to do another pruning pass over the compiler to change all usage of PartialEq to Eq where appropriate. I will do this soon as well.

@sfackler
Copy link
Member

sfackler commented Jun 1, 2014

Should be tagged as [breaking change]

This completes the last stage of the renaming of the comparison hierarchy of
traits. This change renames TotalEq to Eq and TotalOrd to Ord.

In the future the new Eq/Ord will be filled out with their appropriate methods,
but for now this change is purely a renaming change.

[breaking-change]
bors added a commit that referenced this pull request Jun 1, 2014
This completes the last stage of the renaming of the comparison hierarchy of
traits. This change renames TotalEq to Eq and TotalOrd to Ord.

In the future the new Eq/Ord will be filled out with their appropriate methods,
but for now this change is purely a renaming change.

This continues the work of #12517, continuing the work in #14534. This patch accomplishes the final rename of `TotalEq` to `TotalOrd`. I wanted to get this patch landed ASAP so we don't have to deal much with "where did `Eq` and `Ord` go?"

I have yet to do another pruning pass over the compiler to change all usage of `PartialEq` to `Eq` where appropriate. I will do this soon as well.
@bors bors closed this Jun 1, 2014
@bors bors merged commit bba701c into rust-lang:master Jun 1, 2014
@alexcrichton alexcrichton deleted the more-eq-renamings branch June 4, 2014 16:44
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
Fix bug with notifications during initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants