New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ternary Operator #1705

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@pwoolcoc
Contributor

pwoolcoc commented Jan 30, 2012

For issue #1698.

In commit ccebc79, the ternary operator is completely gone.

Commit ac2e855 leaves the definition and helper functions for the operator in, but removes all use of it from src/.

Paul Woolcock added some commits Jan 30, 2012

Paul Woolcock
Alter/remove tests that include/concern ternary
3 tests, pretty/block-disambig.rs, run-pass/operator-overloading.rs,
and run-pass/weird-exprs.rs, all included the ternary operator.  These
were changed to use the if-then-else construct instead.

2 tests, run-pass/block-arg-in-ternary.rs and run-pass/ternary.rs, were
only there because of the ternary operator, and were removed.
Paul Woolcock
Change all ternary ops to if/then/else
All the files below had at least one instance of the ternary operator
present in the source.  All have been changed to the equivalent
if/then/else expression.
Paul Woolcock
Fix last failing test
All tests now pass, without the ternary operator.
Paul Woolcock
Remove ternary operator
`expr_ternary`, `ternary_to_if`, and all parses & lexer definitions have
been removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment