Tidy up some uses of csearch::get_item_path
#27643
Conversation
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| pub fn get_item_name(tcx: &ty::ctxt, def: ast::DefId) -> ast::Name { | ||
| let cstore = &tcx.sess.cstore; | ||
| let cdata = cstore.get_crate_data(def.krate); | ||
| decoder::get_item_name(&*cstore.intr, &*cdata, def) |
|
lgtm, r+ with the nits addressed |
|
Nits addressed. |
|
I would prefer to place |
|
@arielb1 I think this should be fine now. |
|
( |
|
Could you trim the |
|
Updated. r? @arielb1 |
| _ => false, | ||
| } | ||
| } | ||
| intrinsic && self.tcx.item_name(def_id) == "transmute" |
There was a problem hiding this comment.
I guess we should check that this is indeed a foreign fn, but you can't really define extern "rust-intrinsic" fn statics anyway.
|
@bors r+ |
|
📌 Commit d81feb8 has been approved by |
|
⌛ Testing commit d81feb8 with merge a49d9ba... |
(this incidentally fixes an error message where the paths separator is " " instead of "::")
ghost
mentioned this pull request
(this incidentally fixes an error message where the paths separator is " " instead of "::")