Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm-unknown-linux-gnueabi floating-point ABI #30794

Merged
merged 1 commit into from
Jan 13, 2016
Merged

Fix arm-unknown-linux-gnueabi floating-point ABI #30794

merged 1 commit into from
Jan 13, 2016

Conversation

joerg-krause
Copy link
Contributor

gnueabi indicates soft whereas gnueabihf indicates hard floating-point ABI.

gnueabi indicates soft whereas gnueabihf indicates hard floating-point ABI.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@MagaTailor
Copy link

What about -mfloat-abi=softfp? I believe on OpenPandora (at least for pure C/C++ code) this is the way to use the supported NEON instructions.

Maybe that was the original intention to be able to allow the obsolete vfp?

@joerg-krause
Copy link
Contributor Author

The benefit of pure 'soft' binaries is that a soft app can run on a softfp system - but not vice versa.

@alexcrichton
Copy link
Member

@bors: r+ 035a093

Thanks!

@bors
Copy link
Contributor

bors commented Jan 13, 2016

⌛ Testing commit 035a093 with merge b0eec55...

bors added a commit that referenced this pull request Jan 13, 2016
…at-abi, r=alexcrichton

gnueabi indicates soft whereas gnueabihf indicates hard floating-point ABI.
@bors bors merged commit 035a093 into rust-lang:master Jan 13, 2016
@MagaTailor
Copy link

It offends my intelligence to see x86_64 builds/tests being run after changes to some arm .mk files or, as I'd noted previously, README.md!

@joerg-krause joerg-krause deleted the fix-arm-unknown-linux-gnueabi-float-abi branch January 13, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants