-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arm-unknown-linux-gnueabi floating-point ABI #30794
Fix arm-unknown-linux-gnueabi floating-point ABI #30794
Conversation
gnueabi indicates soft whereas gnueabihf indicates hard floating-point ABI.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
What about Maybe that was the original intention to be able to allow the obsolete |
The benefit of pure 'soft' binaries is that a |
…at-abi, r=alexcrichton gnueabi indicates soft whereas gnueabihf indicates hard floating-point ABI.
It offends my intelligence to see x86_64 builds/tests being run after changes to some arm |
gnueabi indicates soft whereas gnueabihf indicates hard floating-point ABI.