Remove str abi fns, send_map helper fns, and other cleanup #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@graydon added some cool magic to send_map to alleviate the need for send_map::linear::str_map, so I removed them from my pull request. |
|
Rewriting C++ code in Rust is awesome. Since this touches so much critical code I'm going to push it to try to make sure all the bots are happy with it. |
|
I got tired of waiting for the bots and pushed to incoming. Full steam ahead. |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Feb 25, 2024
Add "cargo miri clean" command My first reaction when my miri cache was messed up was to attempt run this, which obviously failed. This helps paper over platform differences and such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the string runtime functions could be replaced with pure rust functions. Also there are some minor cleanup like switching result::unwrap with moves, helper functions like send_map::linear::str_map, and etc.