Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly feature gate all unstable ABIs #34904

Merged
merged 1 commit into from Jul 31, 2016

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
I-nominated S-waiting-on-crater T-lang
Projects
None yet
Milestone
No milestone
6 participants
@petrochenkov @pnkfelix @eddyb @nikomatsakis @bors @alexcrichton
@petrochenkov
Copy link
Contributor

petrochenkov commented Jul 18, 2016 •
edited

Fixes #34900
[breaking-change]
r? @pnkfelix

Function-visiting machinery for AST/HIR is surprisingly error-prone, it's very easy to miss some cases or visit something twice while writing a visitor. This is the true problem behind #34900. I'll try to restructure these visitors a bit and send one more PR later.

@rust-highfive rust-highfive assigned pnkfelix Jul 18, 2016

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Jul 19, 2016

@petrochenkov to be honest I was expecting a warning cycle.

For now I'll at least tag this as needing a crater run.

@pnkfelix pnkfelix added the S-waiting-on-crater label Jul 19, 2016

@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

petrochenkov commented Jul 19, 2016

I'd be surprised if it broke anything in practice, but let's see what crater will say.
@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Jul 19, 2016

The patch itself looks fine, so r=me apart from the question of whether it should go through a warning cycle.

I'll nominate for discussion at lang team mtg.

@pnkfelix pnkfelix added T-lang I-nominated labels Jul 19, 2016

@nikomatsakis nikomatsakis assigned nikomatsakis and unassigned pnkfelix Jul 28, 2016

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Jul 28, 2016

Will start a crater run now. Sorry about that, we had network issues with GitHub for a while.
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Jul 29, 2016

Crater report shows 0 regressions.
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jul 29, 2016

OK, let's do it.
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jul 29, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 29, 2016

📌 Commit 9292c0b has been approved by nikomatsakis
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 29, 2016

@bors: rollup

assuming this isn't very platform-specific and green travis means it's good to go whenever

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 30, 2016

@steveklabnik
Rollup merge of rust-lang#34904 - petrochenkov:rustcall, r=nikomatsakis 
Properly feature gate all unstable ABIs

Fixes rust-lang#34900
[breaking-change]
r? @pnkfelix

---
Function-visiting machinery for AST/HIR is surprisingly error-prone, it's *very* easy to miss some cases or visit something twice while writing a visitor. This is the true problem behind rust-lang#34900. I'll try to restructure these visitors a bit and send one more PR later.
a24de0c

@steveklabnik steveklabnik referenced this pull request Jul 30, 2016

Closed

Rollup of 11 pull requests #35125

bors added a commit that referenced this pull request Jul 30, 2016

@bors
Auto merge of #35125 - steveklabnik:rollup, r=steveklabnik 
Rollup of 11 pull requests

- Successful merges: #34904, #35004, #35049, #35058, #35060, #35063, #35080, #35090, #35094, #35104, #35106
- Failed merges:
1224e14
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 30, 2016

⌛️ Testing commit 9292c0b with merge 1225e12...

bors added a commit that referenced this pull request Jul 30, 2016

@bors
Auto merge of #34904 - petrochenkov:rustcall, r=nikomatsakis 
Properly feature gate all unstable ABIs

Fixes #34900
[breaking-change]
r? @pnkfelix

---
Function-visiting machinery for AST/HIR is surprisingly error-prone, it's *very* easy to miss some cases or visit something twice while writing a visitor. This is the true problem behind #34900. I'll try to restructure these visitors a bit and send one more PR later.
1225e12
@bors

@bors bors merged commit 9292c0b into rust-lang:master Jul 31, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@petrochenkov petrochenkov deleted the petrochenkov:rustcall branch Sep 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.