[LLVM 4.0] Update LLVM global variable debug info API for 4.0 #38295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
dylanmckay
force-pushed
the
llvm-4.0-di-globalvar
branch
from
7294ecd
to
c8be658
Compare
|
This will bring us closer to upgrading to LLVM 4.0 in #37609 |
dylanmckay
changed the title
shepmaster
reviewed
Dec 12, 2016
| Constant *InitVal = cast<Constant>(unwrap(Val)); | ||
|
|
||
| #if LLVM_VERSION_GE(4, 0) | ||
| llvm::DIExpression *InitExpr = nullptr; |
There was a problem hiding this comment.
It looks like these are 3 spaces instead of 4?
FYI, this will have some conflicts with #38317.
shepmaster
reviewed
Dec 12, 2016
|
|
||
| #if LLVM_VERSION_GE(4, 0) | ||
| llvm::DIExpression *InitExpr = nullptr; | ||
| if (llvm::ConstantInt *IntVal = llvm::dyn_cast<llvm::ConstantInt>(InitVal)) |
There was a problem hiding this comment.
Should this have braces on the if clause?
dylanmckay
force-pushed
the
llvm-4.0-di-globalvar
branch
from
c8be658
to
5b2b712
Compare
|
@bors r+ Thanks for the PR! |
|
📌 Commit 5b2b712 has been approved by |
|
☔ The latest upstream changes (presumably #38317) made this pull request unmergeable. Please resolve the merge conflicts. |
This teaches Rust about an LLVM 4.0 API change for creating debug info for global variables. This change was made in upstream LLVM patch https://reviews.llvm.org/D20147 This is almost 1:1 copy of how clang did it in http://reviews.llvm.org/D20415
dylanmckay
force-pushed
the
llvm-4.0-di-globalvar
branch
from
5b2b712
to
e080804
Compare
|
Rebased on top of master |
|
@bors r+ |
|
📌 Commit e080804 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 14, 2016
…rister [LLVM 4.0] Update LLVM global variable debug info API for 4.0 This teaches Rust about an LLVM 4.0 API change for creating debug info for global variables. This change was made in upstream LLVM patch https://reviews.llvm.org/D20147 This is almost a 1:1 copy of how clang did it in http://reviews.llvm.org/D20415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This teaches Rust about an LLVM 4.0 API change for creating debug info
for global variables.
This change was made in upstream LLVM patch https://reviews.llvm.org/D20147
This is almost a 1:1 copy of how clang did it in http://reviews.llvm.org/D20415