Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Add timestamps to all build messages #40605

Merged
merged 2 commits into from
Mar 23, 2017

Conversation

alexcrichton
Copy link
Member

When debugging why builds are taking so long it's often useful to get the
timestamp of all log messages as we're not always timing every tiny step of the
build. I wrote a utility for prepending a relative timestamp from the start of
a process which is now downloaded to the builders and is what we wrap the entire
build invocation in.

Closes #40577

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

Note that this PR also disables --enable-quiet-tests on Travis to aid in debugging.

@brson
Copy link
Contributor

brson commented Mar 17, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Mar 17, 2017

📌 Commit 4b25ccd has been approved by brson

@bors
Copy link
Contributor

bors commented Mar 17, 2017

☔ The latest upstream changes (presumably #40575) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Mar 20, 2017

📌 Commit fd6cffc has been approved by brson

@frewsxcv
Copy link
Member

@bors r-

https://travis-ci.org/rust-lang/rust/jobs/213256348

/Users/travis/build.sh: line 229: stamp: command not found

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit 499fb8d has been approved by brson

@bors
Copy link
Contributor

bors commented Mar 21, 2017

🔒 Merge conflict

When debugging why builds are taking so long it's often useful to get the
timestamp of all log messages as we're not always timing every tiny step of the
build. I wrote a [utility] for prepending a relative timestamp from the start of
a process which is now downloaded to the builders and is what we wrap the entire
build invocation in.

[utility]: https://github.com/alexcrichton/stamp-rs

Closes rust-lang#40577
This makes travis problems more difficult to debug, so let's just enable more
verbose logging.
@bstrie
Copy link
Contributor

bstrie commented Mar 21, 2017

@bors r=brson

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit 2727866 has been approved by brson

@bors
Copy link
Contributor

bors commented Mar 23, 2017

⌛ Testing commit 2727866 with merge 8dfc25e...

bors added a commit that referenced this pull request Mar 23, 2017
travis: Add timestamps to all build messages

When debugging why builds are taking so long it's often useful to get the
timestamp of all log messages as we're not always timing every tiny step of the
build. I wrote a [utility] for prepending a relative timestamp from the start of
a process which is now downloaded to the builders and is what we wrap the entire
build invocation in.

[utility]: https://github.com/alexcrichton/stamp-rs

Closes #40577
@bors
Copy link
Contributor

bors commented Mar 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 8dfc25e to master...

@bors bors merged commit 2727866 into rust-lang:master Mar 23, 2017
@alexcrichton alexcrichton deleted the add-stamps branch April 4, 2017 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants