Clean up some code #43006
Merged
Clean up some code #43006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
added
the
S-waiting-on-review
|
ping @nikomatsakis Or if anyone else wants to review it? |
|
I pinged @nikomatsakis on IRC for review a bit earlier. |
nikomatsakis
requested changes
Jul 7, 2017
There was a problem hiding this comment.
What do you think of this as an alternate long explanation? In your version, there were some grammatical errors, and I've tried to keep the overall flow of the explanation, while respecting the overall "error code template" laid out in RFC 1567.
|
Well, it seems good to me so I'll take yours. Thanks for the review! |
GuillaumeGomez
force-pushed
the
e0611-cleanup
branch
from
5ec77e2
to
74de1f2
Compare
|
Ok updated. |
nikomatsakis
approved these changes
Jul 10, 2017
|
@bors r+ |
|
📌 Commit 440e637 has been approved by |
|
🔒 Merge conflict |
GuillaumeGomez
force-pushed
the
e0611-cleanup
branch
from
440e637
to
24a5cea
Compare
|
@bors: r=nikomatsakis |
|
📌 Commit 24a5cea has been approved by |
bors
added a commit
that referenced
this pull request
Jul 11, 2017
Clean up some code From #42669. r? @nikomatsakis
arielb1
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #42669.
r? @nikomatsakis