Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the test for #40003. #45311

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Add the test for #40003. #45311

merged 1 commit into from
Oct 17, 2017

Conversation

goffrie
Copy link
Contributor

@goffrie goffrie commented Oct 15, 2017

I checked that the test failed to compile on an older nightly (I tried 2017-09-29) and that it compiles against master.

Closes #40003.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2017
@aidanhs
Copy link
Member

aidanhs commented Oct 15, 2017

[00:04:08] tidy error: /checkout/src/test/run-pass/issue-40003.rs: incorrect license
[00:04:09] some tidy checks failed
[00:04:09] 
[00:04:09] 
[00:04:09] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/tidy" "/checkout/src" "--no-vendor" "--quiet"
[00:04:09] expected success, got: exit code: 1
[00:04:09] 
[00:04:09] 
[00:04:09] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:09] Build completed unsuccessfully in 0:01:03
[00:04:09] Makefile:77: recipe for target 'tidy' failed
[00:04:09] make: *** [tidy] Error 1

Looks like the license isn't correct on the new test - @goffrie can you add the license and then since @alexcrichton is the reviewer and originally provided the code, part of the review can be agreeing with the license :)

@goffrie
Copy link
Contributor Author

goffrie commented Oct 15, 2017

Oops, thanks.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 16, 2017

📌 Commit 0459166 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2017
@bors
Copy link
Contributor

bors commented Oct 17, 2017

⌛ Testing commit 0459166 with merge 611f375...

bors added a commit that referenced this pull request Oct 17, 2017
Add the test for #40003.

I checked that the test failed to compile on an older nightly (I tried 2017-09-29) and that it compiles against master.

Closes #40003.
@bors
Copy link
Contributor

bors commented Oct 17, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 611f375 to master...

@bors bors merged commit 0459166 into rust-lang:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants