Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Encode linker arguments as UTF-16 on MSVC platforms #48455

Merged
merged 1 commit into from
Feb 26, 2018
Merged

[beta] Encode linker arguments as UTF-16 on MSVC platforms #48455

merged 1 commit into from
Feb 26, 2018

Conversation

Mark-Simulacrum
Copy link
Member

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 24, 2018

📌 Commit a9f3a15 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 24, 2018

🌲 The tree is currently closed for pull requests below priority 900, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2018
@kennytm
Copy link
Member

kennytm commented Feb 24, 2018

@bors p=8

Beta backport

@bors
Copy link
Contributor

bors commented Feb 26, 2018

⌛ Testing commit a9f3a15 with merge 5902706...

bors added a commit that referenced this pull request Feb 26, 2018
@bors
Auto merge of #48455 - Mark-Simulacrum:beta-next, r=alexcrichton
5902706 
[beta] Encode linker arguments as UTF-16 on MSVC platforms

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Feb 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5902706 to beta...

@bors bors merged commit a9f3a15 into rust-lang:beta Feb 26, 2018
@alexcrichton alexcrichton mentioned this pull request Feb 26, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Feb 27, 2018
@kennytm
Rollup merge of rust-lang#48548 - alexcrichton:msvc-linker-utf16, r=a…
2b114da 
…lexcrichton

Encode linker arguments as UTF-16 on MSVC platforms

This is a forward-port of rust-lang#48455 to the master branch
kennytm added a commit to kennytm/rust that referenced this pull request Feb 28, 2018
@kennytm
Rollup merge of rust-lang#48548 - alexcrichton:msvc-linker-utf16, r=a…
59ab146 
…lexcrichton

Encode linker arguments as UTF-16 on MSVC platforms

This is a forward-port of rust-lang#48455 to the master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @rust-highfive @alexcrichton @bors @kennytm