travis: Upgrade OSX builders #48799
travis: Upgrade OSX builders #48799
Conversation
|
r? @kennytm |
alexcrichton
force-pushed
the
more-osx-cores
branch
from
dd82721
to
a3ac9f1
Compare
|
Hm, I'm somewhat hesitant because of the debuginfo breakage but I also think this is somewhat more important -- breakage looks relatively minor. @bors r+ |
|
📌 Commit a3ac9f1 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors: r- Looks like reproducible builds on 64-bit OSX regresses However 32-bit builds get 40 minutes faster, so that's nice! |
bors
added
S-waiting-on-author
alexcrichton
force-pushed
the
more-osx-cores
branch
from
a3ac9f1
to
51321c7
Compare
|
@bors: r=Mark-Simulacrum |
|
📌 Commit 51321c7 has been approved by |
bors
added
S-waiting-on-bors
| @@ -1,5 +1,5 @@ | |||
| -include ../tools.mk | |||
|
|
|||
| all: | |||
| $(RUSTC) foo.rs -g | |||
| $(RUSTC) foo.rs -g -O | |||
There was a problem hiding this comment.
I found this test took forever without optimizations. It still takes a long time with them, but it's at least a little better
| @@ -10,31 +10,27 @@ all: \ | |||
|
|
|||
| smoke: | |||
| rm -rf $(TMPDIR) && mkdir $(TMPDIR) | |||
| $(RUSTC) linker.rs -O | |||
There was a problem hiding this comment.
I rewrote this test to be a little more resilient against system linkers. We're sort of always assuming the system linker is deterministic, and if it's not then there's not much we can do about that...
This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as opposed to the 2 that our builders currently have. Should help make those OSX builds a bit speedier!
alexcrichton
force-pushed
the
more-osx-cores
branch
from
51321c7
to
55a2fdf
Compare
|
@bors: r=Mark-Simulacrum confirmed fixed now! |
|
📌 Commit 55a2fdf has been approved by |
|
@bors: rollup |
…-Simulacrum travis: Upgrade OSX builders This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as opposed to the 2 that our builders currently have. Should help make those OSX builds a bit speedier!
…-Simulacrum travis: Upgrade OSX builders This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as opposed to the 2 that our builders currently have. Should help make those OSX builds a bit speedier!
…-Simulacrum travis: Upgrade OSX builders This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as opposed to the 2 that our builders currently have. Should help make those OSX builds a bit speedier!
|
@bors rollup- p=1 |
travis: Upgrade OSX builders This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as opposed to the 2 that our builders currently have. Should help make those OSX builds a bit speedier!
|
☀️ Test successful - status-appveyor, status-travis |
This upgrades the OSX builders to the
xcode9.3-moarimage which has 3 cores asopposed to the 2 that our builders currently have. Should help make those OSX
builds a bit speedier!