Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments in pull request #51084. #51108

Merged
merged 1 commit into from
May 27, 2018

Conversation

simartin
Copy link
Contributor

This is a follow-up to #51084, that's already been integrated into mainline.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2018
@simartin
Copy link
Contributor Author

r? estebank

@kennytm
Copy link
Member

kennytm commented May 27, 2018

r? @estebank

@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 27, 2018

📌 Commit 9bb939d has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2018
@bors
Copy link
Contributor

bors commented May 27, 2018

⌛ Testing commit 9bb939d with merge f9f66c1...

bors added a commit that referenced this pull request May 27, 2018
Address comments in pull request #51084.

This is a follow-up to #51084, that's already been integrated into mainline.
@bors
Copy link
Contributor

bors commented May 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing f9f66c1 to master...

@bors bors merged commit 9bb939d into rust-lang:master May 27, 2018
@simartin simartin deleted the issue_51022_follow-up branch May 27, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants