Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the llvm-tools component to llvm-tools-preview and tweak its image #51922

Merged
merged 2 commits into from
Jul 1, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Jun 29, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2018
@alexcrichton
Copy link
Member

@bors: try

Gonna make sure the artifacts look all good

@bors
Copy link
Contributor

bors commented Jun 29, 2018

⌛ Trying commit c67566a with merge d5a478cf44181eba766bca09d3081db60f74cda8...

@bors
Copy link
Contributor

bors commented Jun 29, 2018

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton
Copy link
Member

Ok that looks alright but I think there's probably a few more locations that need to be renamed? I think that anywhere rls-preview is mentioned you'll want a similar clause for llvm-tools-preview?

@japaric
Copy link
Member Author

japaric commented Jun 30, 2018

@alexcrichton I think that should do it

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 30, 2018

‼️ Invalid head SHA found, retrying: 0000000000000000000000000000000000000000

@bors
Copy link
Contributor

bors commented Jun 30, 2018

📌 Commit 6531879 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 1, 2018
…richton

rename the llvm-tools component to llvm-tools-preview and tweak its image

as per rust-lang#49584 (comment)

r? @alexcrichton or @Mark-Simulacrum
bors added a commit that referenced this pull request Jul 1, 2018
Rollup of 7 pull requests

Successful merges:

 - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.)
 - #51853 (Fix some doc links)
 - #51890 (Fix inconsequential typo in GlobalAlloc doc example)
 - #51920 (use literal span for concrete type suggestion)
 - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image)
 - #51936 (rename rustc's lld to rust-lld)
 - #51961 (Fix typo in /src/librustc_resolve/lib.rs)

Failed merges:

r? @ghost
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 1, 2018
…richton

rename the llvm-tools component to llvm-tools-preview and tweak its image

as per rust-lang#49584 (comment)

r? @alexcrichton or @Mark-Simulacrum
bors added a commit that referenced this pull request Jul 1, 2018
Rollup of 7 pull requests

Successful merges:

 - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.)
 - #51853 (Fix some doc links)
 - #51890 (Fix inconsequential typo in GlobalAlloc doc example)
 - #51920 (use literal span for concrete type suggestion)
 - #51921 (improve the error message when `#[panic_implementation]` is missing)
 - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image)
 - #51961 (Fix typo in /src/librustc_resolve/lib.rs)

Failed merges:

r? @ghost
@bors bors merged commit 6531879 into rust-lang:master Jul 1, 2018
@japaric japaric deleted the llvm-tools-preview branch July 3, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants