Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep resolved defs in path prefixes and emit them in save-analysis #54145

Merged
merged 10 commits into from
Oct 26, 2018
Merged

Keep resolved defs in path prefixes and emit them in save-analysis #54145

merged 10 commits into from
Oct 26, 2018
+725 −833

Commits on Oct 25, 2018

  1. Give each PathSegment a NodeId

    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    fc67d8f View commit details
    Browse the repository at this point in the history

  2. Store a resolved def on hir::PathSegment

    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    b49da27 View commit details
    Browse the repository at this point in the history

  3. save-analysis: remove hacky, unnecessary code now that we have spans … 

    …for every ident
    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    c2bb7ca View commit details
    Browse the repository at this point in the history

  4. dump data for prefix path segments

    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    609d0bd View commit details
    Browse the repository at this point in the history

  5. dump refs for path segments in save-analysis 

    Requires adding path segments to the hir map
    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    c480386 View commit details
    Browse the repository at this point in the history

  6. Fix tests and rustdoc

    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    cdcbdfd View commit details
    Browse the repository at this point in the history

  7. save-analysis: handle missing field names 

    FIxes rust-lang/rls#1031
    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    8ac3272 View commit details
    Browse the repository at this point in the history

  8. rebasing and reviewer changes 

    Primarily refactoring `(Ident, Option<NodeId>)` to `Segment`
    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    59cb170 View commit details
    Browse the repository at this point in the history

  9. Fix tests and assertions; add some comments

    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    63ac2aa View commit details
    Browse the repository at this point in the history

  10. more reviewer changes

    @nrc
    nrc committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    6dd5bb1 View commit details
    Browse the repository at this point in the history