Bump cargo-vendor version

[pietroalbini]

Currently we pin cargo-vendor to 0.1.4, which doesn't set the User-Agent HTTP header. crates.io is going to require that header in the near future, so this PR bumps the pinned version of the crate to the latest one (which correctly sets the header).

r? @Mark-Simulacrum
cc @sgrif

[Mark-Simulacrum]

It's be great to run a crater-equivalent and file issues against repositories with Cargo.lock files pinging cargo-vendor like this.

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit 8b339b6 has been approved by Mark-Simulacrum

[Mark-Simulacrum]

Oh, also, we should not make this change on crates.io until stable Rust artifacts contain this change to ensure stable builds

[pietroalbini]

@bors r-

Looking at the code a bit more, it might not be the cargo version.

[sgrif]

@Mark-Simulacrum I'm not 100% sure I understand what you mean by

until stable Rust artifacts contain this change to ensure stable builds

[pietroalbini]

@bors r=Mark-Simulacrum p=1

Confirmed this fixes the issue: cargo-vendor 0.1.4 pins cargo 0.16.0, which doesn't set an user agent.

[bors]

📌 Commit 8b339b6 has been approved by Mark-Simulacrum

[Mark-Simulacrum]

@sgrif right now the just-shipped 1.30 rust artifacts don't contain this PR which I think might make it such that distros would be unable to build in some cases if we made the change to crates.io; basically, ideally we'd wait until 1.31 ships to make that change. Does that help?

[sgrif]

@Mark-Simulacrum So the concern is for distros that build from source?

[bors]

⌛ Testing commit 8b339b6 with merge f475375...

[bors]

💔 Test failed - status-travis

[rust-highfive]

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:05:24] 
[00:05:24] Caused by:
[00:05:24]   feature `edition` is required
[00:05:24] 
[00:05:24] this Cargo does not support nightly features, but if you
[00:05:24] switch to nightly channel you can add
[00:05:24] `cargo-features = ["edition"]` to enable this feature
[00:05:24] 
[00:05:24] 
[00:05:24] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "vendor"
[00:05:24] 
[00:05:24] 
[00:05:24] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:05:24] Build completed unsuccessfully in 0:02:16
---
travis_time:end:0a7faa1d:start=1540533255226169726,finish=1540533255233755734,duration=7586008
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a85b042
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ef7194a
travis_time:start:0ef7194a
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:017a7a79
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[rust-highfive]

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:05:29] 
[00:05:29] Caused by:
[00:05:29]   feature `edition` is required
[00:05:29] 
[00:05:29] this Cargo does not support nightly features, but if you
[00:05:29] switch to nightly channel you can add
[00:05:29] `cargo-features = ["edition"]` to enable this feature
[00:05:29] 
[00:05:29] 
[00:05:29] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "vendor"
[00:05:29] 
[00:05:29] 
[00:05:29] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:05:29] Build completed unsuccessfully in 0:02:12
---
travis_time:end:0450beb4:start=1540551403730760736,finish=1540551403740761834,duration=10001098
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0640ffba
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:134ab4b4
travis_time:start:134ab4b4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0349512c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[kennytm]

@bors r-

Looks like it doesn't work 😕

[Mark-Simulacrum]

RUSTC_BOOTSTRAP isn't enough because Cargo uses a different environment variable, IIRC.

[pietroalbini]

Ok, I don't think I can solve this.

cargo-vendor depends on the Cargo version published on crates.io, which is 0.30.0 at the moment and should be 0.31.0 soon. In all those versions the edition key is marked as unstable, and gated with cargo-features = ["edition"].

The problem we're having right now is that Clippy removed the feature gate from its Cargo.toml, but Cargo 0.30.0 expects it even on nightly. So setting up RUSTC_BOOTSTRAP or the Cargo-only equivalent doesn't fix the error.

What should we do?

cc @Manishearth @oli-obk

RUSTC_BOOTSTRAP isn't enough because Cargo uses a different environment variable, IIRC.

Cargo also reads RUSTC_BOOTSTRAP in addition to the override, so that's not the problem.

[Manishearth]

Feel free to add the gate to clippy again

[pietroalbini]

This is blocked on alexcrichton/cargo-vendor#138.
After that PR is merged there will be no need to remove nightly features from Cargo.tomls.

[pietroalbini]

Bumped cargo-vendor to 0.1.19: it's now using Cargo 0.31.0 (with stable edition), and it enables nightly features by default. This should work now.

[pietroalbini]

r? @Mark-Simulacrum

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit 4084eb0 has been approved by Mark-Simulacrum

[pietroalbini]

@bors p=0

Not critical to get this merged as soon as possible, since the crates.io team is not implementing this change right now (and it might not affect us anyway if they continue to allow downloads without an user agent).

[bors]

⌛ Testing commit 4084eb0 with merge 757d6cc...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 757d6cc to master...