Update clippy #55496

Manishearth · 2018-10-30T04:12:46Z

Pulls in rust-lang/rust-clippy#3382, should unbreak clippy

rust-highfive · 2018-10-30T04:12:56Z

⚠️ Warning ⚠️

These commits modify submodules.

rust-highfive · 2018-10-30T04:18:46Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:068f711c:start=1540872877271366948,finish=1540872878352787668,duration=1081420720
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
---
#################################################################         91.5%
######################################################################## 100.0%
[00:01:43] extracting /checkout/obj/build/cache/2018-10-13/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:43]     Updating crates.io index
[00:01:48] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:48] Build completed unsuccessfully in 0:00:17
[00:01:48] Makefile:81: recipe for target 'prepare' failed
[00:01:48] make: *** [prepare] Error 1
[00:01:49] Command failed. Attempt 2/5:
[00:01:49] Command failed. Attempt 2/5:
[00:01:49]     Updating crates.io index
[00:01:49] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:49] Build completed unsuccessfully in 0:00:00
[00:01:49] Makefile:81: recipe for target 'prepare' failed
[00:01:49] make: *** [prepare] Error 1
[00:01:51] Command failed. Attempt 3/5:
[00:01:51] Command failed. Attempt 3/5:
[00:01:51]     Updating crates.io index
[00:01:52] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:52] Build completed unsuccessfully in 0:00:00
[00:01:52] Makefile:81: recipe for target 'prepare' failed
[00:01:52] make: *** [prepare] Error 1
[00:01:55] Command failed. Attempt 4/5:
[00:01:55] Command failed. Attempt 4/5:
[00:01:55]     Updating crates.io index
[00:01:55] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:55] Build completed unsuccessfully in 0:00:00
[00:01:55] Makefile:81: recipe for target 'prepare' failed
[00:01:55] make: *** [prepare] Error 1
[00:01:59] Command failed. Attempt 5/5:
[00:01:59] Command failed. Attempt 5/5:
[00:01:59]     Updating crates.io index
[00:02:00] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:00] Build completed unsuccessfully in 0:00:00
[00:02:00] make: *** [prepare] Error 1
[00:02:00] Makefile:81: recipe for target 'prepare' failed
[00:02:00] The command has failed after 5 attempts.
---
travis_time:end:00facce2:start=1540873008740075546,finish=1540873008746912874,duration=6837328
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1c70c6c1
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03b141f6
travis_time:start:03b141f6
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0005e66a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-10-30T08:21:15Z

@bors r+ p=1

bors · 2018-10-30T08:21:16Z

📌 Commit 49e712f has been approved by oli-obk

bors · 2018-10-30T08:40:37Z

⌛ Testing commit 49e712f with merge 2106f63d03062a0d47c075ab73eb45698d87afb1...

bors · 2018-10-30T10:42:14Z

💔 Test failed - status-travis

rust-highfive · 2018-10-30T10:42:16Z

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:56:52] test process::tests::test_inherit_env ... FAILED
[01:56:52] test process::tests::test_interior_nul_in_arg_is_error ... ok
[01:56:52] test process::tests::test_interior_nul_in_args_is_error ... ok
[01:56:52] test process::tests::test_interior_nul_in_current_dir_is_error ... ok
[01:56:52] thread '<unnamed>' panicked at 'output doesn't contain `RUN_TEST_NEW_ENV2=456`
[01:56:52] ANDROID_ASSETS=/system/app
[01:56:52] ANDROID_BOOTLOGO=1
[01:56:52] ANDROID_DATA=/data
[01:56:52] ANDROID_PROPERTY_WORKSPACE=8,49152
[01:56:52] ANDROID_ROOT=/system
[01:56:52] ANDROID_SOCKET_adbd=9
[01:56:52] ANDROID_STORAGE=/storage
[01:56:52] AR=/android/ndk/arm-14/bin/arm-linux-androideabi-ar
[01:56:52] ASEC_MOUNTPOINT=/mnt/asec
[01:56:52] AWS_ACCESS_KEY_ID=AKIAJAMV3QAMMA6AXHFQ
[01:56:52] AWS_SECRET_ACCESS_KEY=[secure]
[01:56:52] BASHPID=12162
[01:56:52] BOOTCLASSPATH=/system/framework/core.jar:/system/framework/core-junit.jar:/system/framework/bouncycastle.jar:/system/framework/ext.jar:/system/framework/framework.jar:/system/framework/telephony-common.jar:/system/framework/voip-common.jar:/system/framework/mms-common.jar:/system/framework/android.policy.jar:/system/framework/services.jar:/system/framework/apache-xml.jar
[01:56:52] BOOTSTRAP_PARENT_ID=1163
[01:56:52] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[01:56:52] BUILD_DIR=/checkout/obj/build
[01:56:52] CARGO=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo
[01:56:52] CARGO_HOME=/cargo
[01:56:52] CARGO_MANIFEST_DIR=/checkout/src/libstd
[01:56:52] CARGO_MANIFEST_DIR=/checkout/src/libstd
[01:56:52] CARGO_PKG_AUTHORS='The Rust Project Developers'
[01:56:52] CARGO_PKG_DESCRIPTION='The Rust Standard Library'
[01:56:52] CARGO_PKG_HOMEPAGE=
[01:56:52] CARGO_PKG_NAME=std
[01:56:52] CARGO_PKG_VERSION=0.0.0
[01:56:52] CARGO_PKG_VERSION_MAJOR=0
[01:56:52] CARGO_PKG_VERSION_MINOR=0
[01:56:52] CARGO_PKG_VERSION_PATCH=0
[01:56:52] CARGO_PKG_VERSION_PRE=
[01:56:52] CARGO_TARGET_ARM_LINUX_ANDROIDEABI_RUNNER='/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client run'
[01:56:52] CARGO_TARGET_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std
[01:56:52] CC='sccache /android/ndk/arm-14/bin/arm-linux-androideabi-clang'
[01:56:52] CFG_COMPILER_HOST_TRIPLE=arm-linux-androideabi
[01:56:52] CFG_RELEASE_CHANNEL=dev
[01:56:52] CFLAGS='-ffunction-sections -fdata-sections -fPIC --target=arm-linux-androideabi'
[01:56:52] CI_JOB_NAME=arm-android
[01:56:52] COLUMNS
[01:56:52] EPOCHREALTIME=1540895972.695448
[01:56:52] EXTERNAL_STORAGE=/storage/sdcard
[01:56:52] HOME=/home/user
[01:56:52] HOSTNAME=ccdd6d7e07e7
[01:56:52] IFS=$' \t\n'
[01:56:52] KSHEGID=0
[01:56:52] KSHGID=0
[01:56:52] KSHUID=0
[01:56:52] KSH_VERSION='@(#)MIRBSD KSH R43 2013/02/19'
[01:56:52] LD_LIBRARY_PATH=/data/tmp/work:/data/tmp/work/test6142
[01:56:52] LINES
[01:56:52] LOOP_MOUNTPOINT=/mnt/obb
[01:56:52] OPTIND=1
[01:56:52] OUT_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/arm-linux-androideabi/release/build/std-f7ccf77270ea413f/out
[01:56:52] PATH=/sbin:/vendor/bin:/system/sbin:/system/bin:/system/xbin
[01:56:52] PGRP=1418
[01:56:52] PIPESTATUS=0
[01:56:52] PPID=11164
[01:56:52] PS1='# '
[01:56:52] PS2='> '
[01:56:52] PS3='#? '
[01:56:52] PS4='+ '
[01:56:52] PWD=/
[01:56:52] RANDOM=25229
[01:56:52] RANLIB='/android/ndk/arm-14/bin/arm-linux-androideabi-ar s'
[01:56:52] RUSTBUILD_NATIVE_DIR=/checkout/obj/build/arm-linux-androideabi/native
[01:56:52] RUSTC_BOOTSTRAP=1
[01:56:52] RUSTC_CODEGEN_UNITS=1
[01:56:52] RUSTC_DEBUGINFO=false
[01:56:52] RUSTC_DEBUGINFO_LINES=false
[01:56:52] RUSTC_DEBUGINFO_LINES=false
[01:56:52] RUSTC_DEBUG_ASSERTIONS=true
[01:56:52] RUSTC_DENY_WARNINGS=1
[01:56:52] RUSTC_ERROR_METADATA_DST=/checkout/obj/build/tmp/extended-error-metadata
[01:56:52] RUSTC_FORCE_UNSTABLE=1
[01:56:52] RUSTC_LIBDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[01:56:52] RUSTC_METADATA_SUFFIX=rustc
[01:56:52] RUSTC_PRINT_STEP_TIMINGS=1
[01:56:52] RUSTC_REAL=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[01:56:52] RUSTC_RPATH=true
[01:56:52] RUSTC_SNAPSHOT=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustc
[01:56:52] RUSTC_SNAPSHOT_LIBDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib
[01:56:52] RUSTC_STAGE=2
[01:56:52] RUSTC_SYSROOT=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2
[01:56:52] RUSTC_TARGET_LINKER=/android/ndk/arm-14/bin/arm-linux-androideabi-clang
[01:56:52] RUSTC_VERBOSE=0
[01:56:52] RUSTDOC=/checkout/obj/build/bootstrap/debug/rustdoc
[01:56:52] RUSTDOC_CRATE_VERSION=1.31.0-dev
[01:56:52] RUSTDOC_REAL=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc
[01:56:52] RUSTDOC_REAL=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc
[01:56:52] RUST_CONFIGURE_ARGS='--arm-linux-androideabi-ndk=/android/ndk/arm-14 --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --disable-dist-src --enable-debug-assertions --enable-llvm-assertions --set rust.verify-llvm-ir --enable-missing-tools'
[01:56:52] RUST_RELEASE_CHANNEL=nightly
[01:56:52] SCCACHE_BUCKET=rust-lang-ci-sccache2
[01:56:52] SCCACHE_REGION=us-west-1
[01:56:52] SCRIPT='python2.7 ../x.py test --target arm-linux-androideabi'
[01:56:52] SECONDS=0
[01:56:52] SECONDS=0
[01:56:52] SHELL=/bin/bash
[01:56:52] SHLVL=2
[01:56:52] SRC=/checkout
[01:56:52] SSL_CERT_DIR=/usr/lib/ssl/certs
[01:56:52] SSL_CERT_FILE=/usr/lib/ssl/certs/ca-certificates.crt
[01:56:52] TARGETS=arm-linux-androideabi
[01:56:52] TERM=xterm
[01:56:52] TEST_MIRI=false
[01:56:52] TMOUT=0
[01:56:52] TRAVIS=true
[01:56:52] TRAVIS_BRANCH=auto
[01:56:52] USER_ID=0
[01:56:52] USER_ID=0
[01:56:52] WINAPI_NO_BUNDLED_LIBRARIES=1
[01:56:52] _=/bin/sh
[01:56:52] __CARGO_DEFAULT_LIB_METADATA=dev
[01:56:52] ', libstd/process.rs:1916:13
[01:56:52] test process::tests::test_interior_nul_in_env_value_is_error ... ok
[01:56:52] test process::tests::test_interior_nul_in_progname_is_error ... ok
[01:56:52] test process::tests::test_capture_env_at_spawn ... ok
[01:56:52] test process::tests::test_process_output_error ... ignored
---
[01:57:23] 
[01:57:23] error: test failed, to rerun pass '--lib'
[01:57:23] 
[01:57:23] 
[01:57:23] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--"
[01:57:23] 
[01:57:23] 
[01:57:23] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
[01:57:23] Build completed unsuccessfully in 1:43:10
---
travis_time:end:001ce1de:start=1540896015527488991,finish=1540896015545555675,duration=18066684
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:066bbe70
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:007d67a8
travis_time:start:007d67a8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:16b7077c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-10-30T10:51:24Z

@bors retry

Spurious and happened before. Going to file a tracking issue for this.

@oli-obk

Update clippy Pulls in rust-lang/rust-clippy#3382, should unbreak clippy r? @oli-obk @phansch

@ghost

Rollup of 12 pull requests Successful merges: - #54885 (Don't lint 'unused_parens` on `if (break _) { .. }`) - #55205 (Improve a few cases of collecting to an FxHash(Map/Set)) - #55450 (msp430: remove the whole Atomic* API) - #55459 (Add UI test for #49296) - #55472 (Use opt.take() instead of mem::replace(opt, None)) - #55473 (Take advantage of impl Iterator in (transitive/elaborate)_bounds) - #55474 (Fix validation false positive) - #55476 (Change a flat_map with 0/1-element vecs to a filter_map) - #55487 (Adjust Ids of path segments in visibility modifiers) - #55493 (Doc fixes) - #55494 (borrowck=migrate must look at parents of closures) - #55496 (Update clippy) Failed merges: r? @ghost

bors · 2018-10-30T14:20:28Z

⌛ Testing commit 49e712f with merge e8aef7c...

kennytm · 2018-10-31T13:50:52Z

@bors r- retry

rust-highfive assigned oli-obk Oct 30, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2018

Manishearth force-pushed the clippyup branch from cc47ffd to d8fe657 Compare October 30, 2018 04:24

Update clippy

49e712f

Manishearth force-pushed the clippyup branch from d8fe657 to 49e712f Compare October 30, 2018 04:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 30, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2018

kennytm mentioned this pull request Oct 30, 2018

submodules: update clippy from b1d03437 to 3971c424 #55484

Closed

kennytm added a commit to kennytm/rust that referenced this pull request Oct 30, 2018

Rollup merge of rust-lang#55496 - Manishearth:clippyup, r=oli-obk

c16ff6e

Update clippy Pulls in rust-lang/rust-clippy#3382, should unbreak clippy r? @oli-obk @phansch

kennytm mentioned this pull request Oct 30, 2018

Rollup of 12 pull requests #55502

Merged

kennytm mentioned this pull request Oct 30, 2018

Spurious failure in test_inherit_env #55503

Closed

bors merged commit 49e712f into rust-lang:master Oct 30, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update clippy #55496

Update clippy #55496

Manishearth commented Oct 30, 2018

rust-highfive commented Oct 30, 2018

rust-highfive commented Oct 30, 2018

oli-obk commented Oct 30, 2018

bors commented Oct 30, 2018

bors commented Oct 30, 2018

bors commented Oct 30, 2018

rust-highfive commented Oct 30, 2018

kennytm commented Oct 30, 2018

bors commented Oct 30, 2018

kennytm commented Oct 31, 2018

Update clippy #55496

Update clippy #55496

Conversation

Manishearth commented Oct 30, 2018

rust-highfive commented Oct 30, 2018

rust-highfive commented Oct 30, 2018

oli-obk commented Oct 30, 2018

bors commented Oct 30, 2018

bors commented Oct 30, 2018

bors commented Oct 30, 2018

rust-highfive commented Oct 30, 2018

kennytm commented Oct 30, 2018

bors commented Oct 30, 2018

kennytm commented Oct 31, 2018