New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve a few cases of collecting to an FxHash(Map/Set) #55205

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
4 participants
@ljedrz
Contributor

ljedrz commented Oct 19, 2018

Either use collect or procure specified capacity when possible.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Oct 19, 2018

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Contributor

estebank commented Oct 19, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Oct 19, 2018

📌 Commit 3276857 has been approved by estebank

@bors

This comment has been minimized.

Contributor

bors commented Oct 20, 2018

☔️ The latest upstream changes (presumably #55114) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank

This comment has been minimized.

Contributor

estebank commented Oct 28, 2018

@ljedrz You'll need to rebase against latest master.

@ljedrz

This comment has been minimized.

Contributor

ljedrz commented Oct 28, 2018

I know the drill, just haven't had access to a PC for a few days; I'll rebase tomorrow.

@ljedrz

This comment has been minimized.

Contributor

ljedrz commented Oct 29, 2018

@estebank rebased.

@estebank

This comment has been minimized.

Contributor

estebank commented Oct 29, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Contributor

bors commented Oct 29, 2018

📌 Commit 73d4eec has been approved by estebank

kennytm added a commit to kennytm/rust that referenced this pull request Oct 30, 2018

Rollup merge of rust-lang#55205 - ljedrz:faster_fxhashmap/set_populat…
…ion, r=estebank

Improve a few cases of collecting to an FxHash(Map/Set)

Either use `collect` or procure specified capacity when possible.

bors added a commit that referenced this pull request Oct 30, 2018

Auto merge of #55502 - kennytm:rollup, r=kennytm
Rollup of 12 pull requests

Successful merges:

 - #54885 (Don't lint 'unused_parens` on `if (break _) { .. }`)
 - #55205 (Improve a few cases of collecting to an FxHash(Map/Set))
 - #55450 (msp430: remove the whole Atomic* API)
 - #55459 (Add UI test for #49296)
 - #55472 (Use opt.take() instead of mem::replace(opt, None))
 - #55473 (Take advantage of impl Iterator in (transitive/elaborate)_bounds)
 - #55474 (Fix validation false positive)
 - #55476 (Change a flat_map with 0/1-element vecs to a filter_map)
 - #55487 (Adjust Ids of path segments in visibility modifiers)
 - #55493 (Doc fixes)
 - #55494 (borrowck=migrate must look at parents of closures)
 - #55496 (Update clippy)

Failed merges:

r? @ghost

@bors bors merged commit 73d4eec into rust-lang:master Oct 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ljedrz ljedrz deleted the ljedrz:faster_fxhashmap/set_population branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment