Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #55746

Merged
merged 31 commits into from
Nov 7, 2018
Merged

Rollup of 14 pull requests #55746

merged 31 commits into from
Nov 7, 2018

Commits on Oct 26, 2018

  1. Slight copy-editing for std::cell::Cell docs

    Hopefully this is a bit more precise and also more correct English.
    goffrie committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    6df57a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2018

  1. Configuration menu
    Copy the full SHA
    42d3ef7 View commit details
    Browse the repository at this point in the history
  2. Choose predicates without inference variables over those with them

    Fixes rust-lang#54705
    
    When constructing synthetic auto trait impls, we may come across
    multiple predicates involving the same type, trait, and substitutions.
    Since we can only display one of these, we pick the one with the 'most
    strict' lifetime paramters. This ensures that the impl we render the
    user is actually valid (that is, a struct matching that impl will
    actually implement the auto trait in question).
    
    This commit exapnds the definition of 'more strict' to take into account
    inference variables. We always choose a predicate without inference
    variables over a predicate with inference variables.
    Aaron1011 committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    20aa751 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2018

  1. Don't print opt fuel messages to stdout because it breaks Rustbuild

    Rustbuild passes `--message-format json` to the compiler invocations
    which causes JSON to be emitted on stdout. Printing optimization fuel
    messages to stdout breaks the json and causes Rustbuild to fail.
    
    Work around this by emitting optimization fuel related messages on
    stderr instead.
    wesleywiser committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    a7bea73 View commit details
    Browse the repository at this point in the history
  2. Make process_obligations' computation of completed optional.

    It's only used in tests.
    
    This reduces instruction counts on several benchmarks by 0.5--1%.
    nnethercote committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    dbc3c6e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d22ae75 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Configuration menu
    Copy the full SHA
    84775ed View commit details
    Browse the repository at this point in the history
  2. Add aarch64-pc-windows-msvc to deployed targets

    Accidentally forgotten from rust-lang#54718!
    alexcrichton committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    842914e View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Configuration menu
    Copy the full SHA
    a1c4060 View commit details
    Browse the repository at this point in the history
  2. Add explcit --error-format options to tests of print-fuel to sidest…

    …ep compiletests presumption of JSON.
    
    As a driveby, rename the stdout files to stderr, which should have been part of the earlier commit.
    pnkfelix committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    22b571d View commit details
    Browse the repository at this point in the history
  3. Run name-anon-globals after LTO passes as well

    If we're going to emit bitcode (through ThinLTOBuffer), then we
    need to ensure that anon globals are named. This was already done
    after optimization passes, but also has to happen after LTO passes,
    as we always emit the final result in a ThinLTO-compatible manner.
    
    Fixes rust-lang#51947.
    nikic committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    66702fc View commit details
    Browse the repository at this point in the history
  4. Update lldb

    This updates lldb to pick up some bug fixes, and makes one minor test
    suite fix to account for this.
    tromey committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    2869fda View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    46fcf1c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    eca11b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. Rollup merge of rust-lang#55377 - goffrie:patch-2, r=joshtriplett

    Slight copy-editing for `std::cell::Cell` docs
    
    Hopefully this is a bit more precise and also more correct English.
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    ac9d5ec View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#55441 - xfix:patch-12, r=aturon

    Remove unused re import in gdb_rust_pretty_printing
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    0156dd2 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#55453 - Aaron1011:fix/rustdoc-lifetime, r=p…

    …nkfelix
    
    Choose predicates without inference variables over those with them
    
    Fixes rust-lang#54705
    
    When constructing synthetic auto trait impls, we may come across
    multiple predicates involving the same type, trait, and substitutions.
    Since we can only display one of these, we pick the one with the 'most
    strict' lifetime paramters. This ensures that the impl we render the
    user is actually valid (that is, a struct matching that impl will
    actually implement the auto trait in question).
    
    This commit exapnds the definition of 'more strict' to take into account
    inference variables. We always choose a predicate without inference
    variables over a predicate with inference variables.
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    88f214c View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#55495 - wesleywiser:opt_fuel_rustbuild, r=n…

    …ikomatsakis
    
    Don't print opt fuel messages to stdout because it breaks Rustbuild
    
    Rustbuild passes `--message-format json` to the compiler invocations
    which causes JSON to be emitted on stdout. Printing optimization fuel
    messages to stdout breaks the json and causes Rustbuild to fail.
    
    Work around this by emitting optimization fuel related messages on
    stderr instead.
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    099c587 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#55501 - nnethercote:DoCompleted, r=pnkfelix

    Make `process_obligations`' computation of `completed` optional.
    
    It's only used in tests.
    
    This reduces instruction counts on several benchmarks by 0.5--1%.
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    d64142b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#55510 - bitshifter:repr-feature-gate-fix, r…

    …=petrochenkov
    
    Fix feature gate only being checked on first repr attr.
    
    Reported in rust-lang#33158 (comment).
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    0708a6a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#55609 - nikic:fix-51947, r=nagisa

    Run name-anon-globals after LTO passes as well
    
    If we're going to emit bitcode (through ThinLTOBuffer), then we need to ensure that anon globals are named. This was already done after optimization passes, but also has to happen after LTO passes, as we always emit the final result in a ThinLTO-compatible manner.
    
    I added the test as `run-make`. The important bit is that we emit bitcode in some way (e.g. `--crate-type rlib` or `--emit=llvm-bc`). Please tell me if there is a better way to test for that.
    
    Fixes rust-lang#51947
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    dfa104e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#55688 - alexreg:move-issue-tests, r=estebank

    Standardised names and location of ui issue tests
    
    None
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    8f93a3c View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#55692 - matthiaskrgr:remark_debuginfo_hint,…

    … r=michaelwoerister
    
    -C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n"
    
    Previously suggested "--debuginfo" does not actually work.
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    3682d31 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#55702 - alexcrichton:arm64-msvc-deploy, r=m…

    …ichaelwoerister
    
    Add `aarch64-pc-windows-msvc` to deployed targets
    
    Accidentally forgotten from rust-lang#54718!
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    6f10e34 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9dba743 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b42b9b3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3ec8974 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#55728 - tromey:update-lldb, r=alexcrichton

    Update lldb
    
    This updates lldb to pick up some bug fixes, and makes one minor test
    suite fix to account for this.
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    dd9ea2a View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#55730 - estebank:impl-trait-arg-mismatch, r…

    …=varkor
    
    Use trait impl method span when type param mismatch is due to impl Trait
    
    Fix rust-lang#55374.
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    e222d1d View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#55734 - teresy:shorthand-fields, r=davidtwco

    refactor: use shorthand fields
    
    refactor: use shorthand for single fields everywhere (excluding tests).
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    9d9146a View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#55645 - RalfJung:validity-range-inclusive, …

    …r=oli-obk
    
    do not print wrapping ranges like normal ranges in validity diagnostics
    kennytm committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    4e86576 View commit details
    Browse the repository at this point in the history