Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `process_obligations`' computation of `completed` optional. #55501

Merged
merged 1 commit into from Nov 7, 2018

Conversation

@nnethercote
Copy link
Contributor

commented Oct 30, 2018

It's only used in tests.

This reduces instruction counts on several benchmarks by 0.5--1%.

Make `process_obligations`' computation of `completed` optional.
It's only used in tests.

This reduces instruction counts on several benchmarks by 0.5--1%.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Oct 30, 2018

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

📌 Commit dbc3c6e has been approved by pnkfelix

kennytm added a commit to kennytm/rust that referenced this pull request Nov 6, 2018

Rollup merge of rust-lang#55501 - nnethercote:DoCompleted, r=pnkfelix
Make `process_obligations`' computation of `completed` optional.

It's only used in tests.

This reduces instruction counts on several benchmarks by 0.5--1%.

bors added a commit that referenced this pull request Nov 6, 2018

Auto merge of #55710 - kennytm:rollup, r=kennytm
Rollup of 13 pull requests

Successful merges:

 - #55490 (resolve: Fix ICE in macro import error recovery)
 - #55501 (Make `process_obligations`' computation of `completed` optional.)
 - #55597 (std: Enable usage of `thread_local!` through imports)
 - #55601 (Fix tracking issue numbers for some unstable features)
 - #55621 (Add precision for create_dir function)
 - #55626 (Update emscripten)
 - #55644 (ci: Add Dockerfile for dist-powerpcspe-linux)
 - #55664 (Make "all possible cases" help message uniform with existing help messages)
 - #55689 (miri: binary_op_val -> binary_op_imm)
 - #55694 (Fixes #31076)
 - #55696 (NLL Diagnostic Review 3: Missing errors for borrows of union fields )
 - #55700 (Update ui tests with respect to NLL)
 - #55703 (Update `configure --help` (via configure.py) to reflect decoupling of debug+optimize)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Nov 7, 2018

Rollup merge of rust-lang#55501 - nnethercote:DoCompleted, r=pnkfelix
Make `process_obligations`' computation of `completed` optional.

It's only used in tests.

This reduces instruction counts on several benchmarks by 0.5--1%.

bors added a commit that referenced this pull request Nov 7, 2018

Auto merge of #55746 - kennytm:rollup, r=kennytm
Rollup of 15 pull requests

Successful merges:

 - #55377 (Slight copy-editing for `std::cell::Cell` docs)
 - #55441 (Remove unused re import in gdb_rust_pretty_printing)
 - #55453 (Choose predicates without inference variables over those with them)
 - #55495 (Don't print opt fuel messages to stdout because it breaks Rustbuild)
 - #55501 (Make `process_obligations`' computation of `completed` optional.)
 - #55510 (Fix feature gate only being checked on first repr attr.)
 - #55609 (Run name-anon-globals after LTO passes as well)
 - #55688 (Standardised names and location of ui issue tests)
 - #55692 (-C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n")
 - #55702 (Add `aarch64-pc-windows-msvc` to deployed targets)
 - #55717 (Bubble up an overflow error so that rustdoc can ignore it)
 - #55719 (Sidestep link error from rustfix'ed code by using a *defined* static.)
 - #55728 (Update lldb)
 - #55730 (Use trait impl method span when type param mismatch is due to impl Trait)
 - #55734 (refactor: use shorthand fields)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Nov 7, 2018

Auto merge of #55746 - kennytm:rollup, r=kennytm
Rollup of 14 pull requests

Successful merges:

 - #55377 (Slight copy-editing for `std::cell::Cell` docs)
 - #55441 (Remove unused re import in gdb_rust_pretty_printing)
 - #55453 (Choose predicates without inference variables over those with them)
 - #55495 (Don't print opt fuel messages to stdout because it breaks Rustbuild)
 - #55501 (Make `process_obligations`' computation of `completed` optional.)
 - #55510 (Fix feature gate only being checked on first repr attr.)
 - #55609 (Run name-anon-globals after LTO passes as well)
 - #55645 (do not print wrapping ranges like normal ranges in validity diagnostics)
 - #55688 (Standardised names and location of ui issue tests)
 - #55692 (-C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n")
 - #55702 (Add `aarch64-pc-windows-msvc` to deployed targets)
 - #55728 (Update lldb)
 - #55730 (Use trait impl method span when type param mismatch is due to impl Trait)
 - #55734 (refactor: use shorthand fields)

@bors bors merged commit dbc3c6e into rust-lang:master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

alexreg added a commit to alexreg/rust that referenced this pull request Nov 7, 2018

Auto merge of rust-lang#55746 - kennytm:rollup, r=kennytm
Rollup of 14 pull requests

Successful merges:

 - rust-lang#55377 (Slight copy-editing for `std::cell::Cell` docs)
 - rust-lang#55441 (Remove unused re import in gdb_rust_pretty_printing)
 - rust-lang#55453 (Choose predicates without inference variables over those with them)
 - rust-lang#55495 (Don't print opt fuel messages to stdout because it breaks Rustbuild)
 - rust-lang#55501 (Make `process_obligations`' computation of `completed` optional.)
 - rust-lang#55510 (Fix feature gate only being checked on first repr attr.)
 - rust-lang#55609 (Run name-anon-globals after LTO passes as well)
 - rust-lang#55645 (do not print wrapping ranges like normal ranges in validity diagnostics)
 - rust-lang#55688 (Standardised names and location of ui issue tests)
 - rust-lang#55692 (-C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n")
 - rust-lang#55702 (Add `aarch64-pc-windows-msvc` to deployed targets)
 - rust-lang#55728 (Update lldb)
 - rust-lang#55730 (Use trait impl method span when type param mismatch is due to impl Trait)
 - rust-lang#55734 (refactor: use shorthand fields)

@nnethercote nnethercote deleted the nnethercote:DoCompleted branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.