-C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n" #55692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of "-C debuginfo=n"
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks for the PR, @matthiaskrgr! @bors r+ rollup |
|
📌 Commit 84775ed has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 7, 2018
… r=michaelwoerister -C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n" Previously suggested "--debuginfo" does not actually work.
bors
added a commit
that referenced
this pull request
Nov 7, 2018
Rollup of 14 pull requests Successful merges: - #55377 (Slight copy-editing for `std::cell::Cell` docs) - #55441 (Remove unused re import in gdb_rust_pretty_printing) - #55453 (Choose predicates without inference variables over those with them) - #55495 (Don't print opt fuel messages to stdout because it breaks Rustbuild) - #55501 (Make `process_obligations`' computation of `completed` optional.) - #55510 (Fix feature gate only being checked on first repr attr.) - #55609 (Run name-anon-globals after LTO passes as well) - #55645 (do not print wrapping ranges like normal ranges in validity diagnostics) - #55688 (Standardised names and location of ui issue tests) - #55692 (-C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n") - #55702 (Add `aarch64-pc-windows-msvc` to deployed targets) - #55728 (Update lldb) - #55730 (Use trait impl method span when type param mismatch is due to impl Trait) - #55734 (refactor: use shorthand fields)
alexreg
pushed a commit
to alexreg/rust
that referenced
this pull request
Nov 7, 2018
Rollup of 14 pull requests Successful merges: - rust-lang#55377 (Slight copy-editing for `std::cell::Cell` docs) - rust-lang#55441 (Remove unused re import in gdb_rust_pretty_printing) - rust-lang#55453 (Choose predicates without inference variables over those with them) - rust-lang#55495 (Don't print opt fuel messages to stdout because it breaks Rustbuild) - rust-lang#55501 (Make `process_obligations`' computation of `completed` optional.) - rust-lang#55510 (Fix feature gate only being checked on first repr attr.) - rust-lang#55609 (Run name-anon-globals after LTO passes as well) - rust-lang#55645 (do not print wrapping ranges like normal ranges in validity diagnostics) - rust-lang#55688 (Standardised names and location of ui issue tests) - rust-lang#55692 (-C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n") - rust-lang#55702 (Add `aarch64-pc-windows-msvc` to deployed targets) - rust-lang#55728 (Update lldb) - rust-lang#55730 (Use trait impl method span when type param mismatch is due to impl Trait) - rust-lang#55734 (refactor: use shorthand fields)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously suggested "--debuginfo" does not actually work.